From: Jonthan Haslam <jonathan.haslam@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-trace-kernel@vger.kernel.org, andrii@kernel.org,
bpf@vger.kernel.org, rostedt@goodmis.org, mhiramat@kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uprobes: reduce contention on uprobes_tree access
Date: Mon, 25 Mar 2024 19:12:29 +0000 [thread overview]
Message-ID: <syviklbpdblcwr3l2seuwyzfrg2hy2shx5f6ho6yf4s4ce63tc@nbo4by247y6z> (raw)
In-Reply-To: <Zf+d9twfyIDosINf@gmail.com>
Hi Ingo,
> > This change has been tested against production workloads that exhibit
> > significant contention on the spinlock and an almost order of magnitude
> > reduction for mean uprobe execution time is observed (28 -> 3.5 microsecs).
>
> Have you considered/measured per-CPU RW semaphores?
No I hadn't but thanks hugely for suggesting it! In initial measurements
it seems to be between 20-100% faster than the RW spinlocks! Apologies for
all the exclamation marks but I'm very excited. I'll do some more testing
tomorrow but so far it's looking very good.
Thanks again for the input.
Jon.
next prev parent reply other threads:[~2024-03-25 19:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 14:57 [PATCH] uprobes: reduce contention on uprobes_tree access Jonathan Haslam
2024-03-21 16:11 ` Andrii Nakryiko
2024-03-24 3:28 ` Ingo Molnar
2024-03-25 19:12 ` Jonthan Haslam [this message]
2024-03-25 23:14 ` Andrii Nakryiko
2024-03-26 11:55 ` Jonthan Haslam
2024-03-25 3:03 ` Masami Hiramatsu
2024-03-25 19:04 ` Jonthan Haslam
2024-03-26 23:42 ` Masami Hiramatsu
2024-03-26 16:01 ` Andrii Nakryiko
2024-03-26 23:42 ` Masami Hiramatsu
2024-03-27 17:06 ` Jonthan Haslam
2024-03-28 0:18 ` Masami Hiramatsu
2024-03-28 0:45 ` Andrii Nakryiko
2024-03-29 17:33 ` Andrii Nakryiko
2024-03-30 0:36 ` Masami Hiramatsu
2024-03-30 5:26 ` Andrii Nakryiko
2024-04-10 10:38 ` Jonthan Haslam
2024-04-10 23:21 ` Masami Hiramatsu
2024-04-11 8:41 ` Jonthan Haslam
2024-04-18 11:10 ` Jonthan Haslam
2024-04-19 0:43 ` Masami Hiramatsu
2024-04-03 11:05 ` Jonthan Haslam
2024-04-03 17:50 ` Andrii Nakryiko
2024-04-04 10:45 ` Jonthan Haslam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=syviklbpdblcwr3l2seuwyzfrg2hy2shx5f6ho6yf4s4ce63tc@nbo4by247y6z \
--to=jonathan.haslam@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.