From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE096C433F5 for ; Mon, 10 Jan 2022 07:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MrBJBuaY7iS4Dkqmhk0ERQO6Ja/0qp0Ck0Vot1/PGa0=; b=0n0TRSjIivSSC1 KvE01aCSk6PscAGO7GYx95i1cH9egzRlN3EDKkvQha+95QhC83iPo5EgLcvtvFpf+OMPFQIWa2gbC u/Yg8Zd3TEe+lfbll2k2fWeV+lZwsgPOKmcuQh6lddfqOyomZTLxNPjjBxe7VoZuSULkBQCkR77bS 6EDVW059uTNESURXXtyGCV8/AS4AdCt5laaoU3HnAl2ZDgoby5Td+X8lo4nEeOTZxkdD8SxOAHMBO 9X+tiY/AS45dtEXtSOFUnlIjcPXZvRC2HDCU4pRCLq4C+4XIdPv0hPJha9P5KqeWbnSdLP4vIf2ax wHfsE8evJ5iXkQ7LpLVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6pOd-009i5S-0F; Mon, 10 Jan 2022 07:47:15 +0000 Received: from out203-205-221-236.mail.qq.com ([203.205.221.236]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6pOY-009i3R-Be for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 07:47:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1641800824; bh=4/D9bsQYTExfGj/Kw0XJPUykeRczvoxzNQdeTQGgfuU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Q5sBS8SKpdlX7a6uZhX74qmMZZ79nyWGVZHy4jmxdLiqFaVsB3MvxYgxyGs8PeDal 2lK9kdAtHrqZIM7jZQFWZRVKYURtDhySUT7GWtpryq1DBJFyRQIFvdQLlgzcwCL5vp LGfQu76BzlCmpI9fVrUzUmpdQH0GeQLZ//sb/p1Y= Received: from localhost ([119.32.47.91]) by newxmesmtplogicsvrszc11.qq.com (NewEsmtp) with SMTP id BC28D21C; Mon, 10 Jan 2022 15:47:02 +0800 X-QQ-mid: xmsmtpt1641800822tp8masu2j Message-ID: X-QQ-XMAILINFO: OfSYiviZO9YdmdcN850B6VCN5Oun1MpScidBKLKEp7n/KUBzvVWUy7r/3bu2W7 +6drgSgykPAuOjYqgg5zL+lFC9XKXiYNILxmjF6UYaFDITEVjM4RFT5CbZme/Ntb2O1+e/nLh5bS OltW0hy1Q7GeBLvee725G75N6/AqIlWNXcP6H/WRcTpZRvcVukwJhBN+f96s/OvR2sAyOXPm5L3b mXLpdbmUgIHNSMDluBc0RN4cSUrzj/YDlPW+GXBPChp5QUawTbA463xv/ltFXEKfWbpp8YAbihz9 YJnaAnwWmxPQFVCGvv1Ns8tcOEQIZIrX60OOg8g8w9xLTPg0nEXC6+im/vE1cYcZbU0/UdrYNK29 drzBGlNd+UwAsgaFOI34xhYNypwov/Kaw9Ri9OGkuERcIUypQV2mWmoX20mbmkuE7KVZgkoAkPP0 ku3I4v41RHbq44WEe8Fq+zdzi5sPaebxlayMqWk5JzfbUSChamgWc4IrOxqNiACWf1+FizIIu1nJ 48PxKoWzxjs4DjSsaNxo2gophzwmdhjy4G1Q9C4snwN8mNPqp/kBCd2/E8d0PDYAiX3qbqStwEDg 3cnPfZsYVWB2vZ/EK1QDOHrHQPyGqk5PatjgnZHxOw/0qgLq0FilBDCrL7hOKUTz0ZtFsffw/Gg7 m07cABaDstdZAz6wgieiGzrn9a2T2dePd9WiP2TxKW1P2sA/6MyWOJHp3N5u69okDU3RuX1GNmSQ 6EmoQHbU1H8CoykI4rraXuAE8Zbh9guwoQdYLDxqc1pRaGNpldgBfyT/U9bb9P+9HDfaR0yvMes8 lyiw4B98NOAm9NUDOhkVmuAnE1Mi8nGr3ONlNhi/3bSN6/pckAnihbmXueKCsD9N5PrCIyLH3baO zzjXf6ATYN Date: Mon, 10 Jan 2022 15:47:02 +0800 From: Conley Lee To: Corentin Labbe Cc: davem@davemloft.net, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] sun4i-emac.c: enable emac tx dma X-OQ-MSGID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220109_234710_782081_965E5B83 X-CRM114-Status: GOOD ( 25.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDEvMDkvMjIgYXQgMDk6NDXkuIvljYgsIENvcmVudGluIExhYmJlIHdyb3RlOgo+IERhdGU6 IFN1biwgOSBKYW4gMjAyMiAyMTo0NTowMSArMDEwMAo+IEZyb206IENvcmVudGluIExhYmJlIDxj bGFiYmUubW9udGpvaWVAZ21haWwuY29tPgo+IFRvOiBjb25sZXlsZWVAZm94bWFpbC5jb20KPiBD YzogZGF2ZW1AZGF2ZW1sb2Z0Lm5ldCwgbXJpcGFyZEBrZXJuZWwub3JnLCB3ZW5zQGNzaWUub3Jn LAo+ICBqZXJuZWouc2tyYWJlY0BnbWFpbC5jb20sIG5ldGRldkB2Z2VyLmtlcm5lbC5vcmcsCj4g IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZywgbGludXgtc3VueGlAbGlzdHMu bGludXguZGV2LAo+ICBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCj4gU3ViamVjdDogUmU6 IFtQQVRDSCB2MV0gc3VuNGktZW1hYy5jOiBlbmFibGUgZW1hYyB0eCBkbWEKPiAKPiBMZSBTdW4s IEphbiAwOSwgMjAyMiBhdCAwNToxNzo1NVBNICswODAwLCBjb25sZXlsZWVAZm94bWFpbC5jb20g YSDDqWNyaXQgOgo+ID4gRnJvbTogY29ubGV5IDxjb25sZXlsZWVAZm94bWFpbC5jb20+Cj4gPiAK PiA+IEhlbGxvCj4gPiBJIGFtIHJlYWRpbmcgdGhlIFI0MCB1c2VyIG1hbnVhbCBhbmQgdHJ5aW5n IHRvIGNyZWF0ZSBhIG5ldyBwYXRoIHRvIGVuYWJsZQo+ID4gZW1hYyB0eCBkbWEgY2hhbm5lbC4g QWNjb3JkaW5nIHRvIHRoZSBmaWd1cmUgOC0yMShUWCBPcGVyYXRpb24gRGlhZ3JhbSksCj4gPiBJ IHRyeSB0byBlbmFibGUgZW1hYyB0eCBkbWEgY2hhbm5lbCBieSB0aGUgZm9sbG93IHN0ZXBzOgo+ ID4gMS4gZW5hYmxlIHR4IGRtYSBtb2RlCj4gPiAyLiBzZXQgcGFja2V0IGxlbmd0aHMKPiA+IDIu IG1vdmUgZGF0YSBmcm9tIHNrYiB0byB0eCBmaWZvIGJ5IHVzaW5nIGRtYSBpbiB4bWl0IGZ1bmN0 aW9uLgo+ID4gMy4gc3RhcnQgdHJhbnNmZXIgZnJvbSB0eCBmaWZvIHRvIHBoeSBpbiBkbWEgdHgg ZG9uZSBjYWxsYmFjawo+ID4gCj4gPiBCdXQgaXQgZG9lc24ndCB3b3JrLiBlbWFjIHR4IGludGVy cnVwdCBhbmQgZG1hIGZpbmlzaGVkIGludGVycnVwdCBhcmUKPiA+IHJhaXNlZCwgYnV0IG5vIHBh Y2tldHMgYXJlIHRyYW5zbWl0dGVkIChJIHRlc3QgaXQgYnkgdGNwZHVtcCkuCj4gPiBEbyB5b3Ug a25vdyBob3cgdG8gY29uZmlndXJlIHRoZSBlbWFjIHR4IGRtYSBjb3JyZWN0bHk/IFRoYW5rcyB+ Cj4gPiAKPiAKPiBIZWxsbwo+IAo+IEhlcmUgYXJlIG15IHRob3VnaHRzIHRvIGhlbHAgeW91Ogo+ IC0gWW91ciBlbWFpbCBpcyBub3QgYSByZWFsIHBhdGNoLCBidXQgYW4gYXNrIGZvciBoZWxwLCBz byB5b3Ugc2hvdWxkIG5vdCB1c2UgWyBQQVRDSCBdIGluIHRoZSBzdWJqZWN0Lgo+IC0gSWYgaXQg d2FzIGEgcGF0Y2gsICJ2MSIgaXMgbm90IG5lY2Vzc2FyeQo+IC0gWW91ciBwYXRjaCBiZWxvdyBp cyBkb2luZyB0b28gbWFueSB1bnJlbGF0ZWQgZGlmZmVyZW50IHRoaW5ncywgaXQgaXMgaGFyZCB0 byBzZWUgdGhlIERNQSBUWCBlbmFibGUgcGFydAo+IC0gSSB0aGluayB5b3UgY291bGQgZmlyc3Qg c2VuZCBhIHByZWxpbWluYXJ5IHBhdGNoIHdoaWNoIGFkZHMgYWxsIEVNQUNfSU5UX0NUTF9UWF94 eHggd2hpY2ggYXJlIGFscmVhZHkgdXNlZCBieSB0aGUgZHJpdmVyICh0byByZWR1Y2UgdGhlIGRp ZmYpCj4gLSBXaXRob3V0IHRoZSBEVEIgY2hhbmdlLCBpdCBpcyBoYXJkIHRvIHNlZSB0aGUgd2hv bGUgcGljdHVyZSwgZGlkIHlvdSBjb3JyZWN0bHkgdXNlIHRoZSByaWdodCBkbWEgbnVtYmVyIGZv ciBhbiBlYXN5IGV4YW1wbGUuCj4gLSBLbm93aW5nIGFsc28gdGhlIGJvYXJkIChhbmQgc28gUEhZ LCBtb2RlcyBldGMuLi4pIGNvdWxkIGhlbHAKPiAtIEkgdGhpbmsgeW91ciBwcmlvcml0eSBzaG91 bGQgbm90IHRvIGFkZCBUWCwgYnV0IHRvIGZpeCByZXBvcnRlZCBwcm9ibGVtcyB0byB5b3VyIGlu aXRpYWwgcGF0Y2ggKGJ1aWxkIHdhcm5pbmdzL2Vycm9yIGh0dHBzOi8vbWFyYy5pbmZvLz9sPWxp bnV4LWFybS1rZXJuZWwmbT0xNjQxNTk4NDYyMTM1ODUmdz0yKSBzaW5jZSB5b3VyIHdvcmsgb24g VFggd2lsbCBuZWVkIHRvIGJlIGFwcGxpZWQgYWZ0ZXIgdGhpcy4KPiAtIEZvciB0aGUgcHJldmlv dXMgcG9pbnQsIGFsd2F5cyBidWlsZCB0ZXN0IHdpdGggYXQgbGVhc3QgMiBkaWZmZXJlbnQgMzIv NjQgYXJjaC4gQW5kIGlmIHBvc3NpYmxlIGEgdG90YWwgZGlmZmVyZW50IGFyY2ggKGxpa2UgeDg2 XzY0KS4KPiAKPiBBbnl3YXksIEkgd2lsbCB0cnkgdG8gdGVzdCB5b3VyIHBhdGNoIG9uIG15IGEx MCBib2FyZAo+IAo+IFJlZ2FyZHMKVGhhbmtzIGEgbG90IGZvciB5b3VyIGhlbHAgfiBJIHdpbGwg c3VibWl0IGFuIHBhdGNoIHdoaWNoIGFkZCBhbGwKcmVnaXN0ZXIgcmVsYXRlZC4gQnkgdGhlIHdh eSwgdGhlIGJ1aWxkIHdhcm5pbmdzIHByb2JsZW1zIGhhdmUgYmVlbiBmaXhlZApieSBKYWt1YiBL aWNpbnNraSA8a3ViYUBrZXJuZWwub3JnPi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84ECC2C80 for ; Mon, 10 Jan 2022 07:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1641801027; bh=4/D9bsQYTExfGj/Kw0XJPUykeRczvoxzNQdeTQGgfuU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YtJ8CrACJqpV78bbfEXJsna9tuAQlgX/axMCKG2BPXwBRAvjAv9r1j5C4hg58eUdr xM7TCBHXR4tLU5KckQPo3jGUDXx/0/yUyPi85f2ggHkv6kcdSMmDQQNXLvOjCFwFBJ QtJvOkBUBI3kfzt5Sy4BVItbzyeKTNYdDE4BxH34= Received: from localhost ([119.32.47.91]) by newxmesmtplogicsvrszc11.qq.com (NewEsmtp) with SMTP id BC28D21C; Mon, 10 Jan 2022 15:47:02 +0800 X-QQ-mid: xmsmtpt1641800822tp8masu2j Message-ID: X-QQ-XMAILINFO: OfSYiviZO9YdmdcN850B6VCN5Oun1MpScidBKLKEp7n/KUBzvVWUy7r/3bu2W7 +6drgSgykPAuOjYqgg5zL+lFC9XKXiYNILxmjF6UYaFDITEVjM4RFT5CbZme/Ntb2O1+e/nLh5bS OltW0hy1Q7GeBLvee725G75N6/AqIlWNXcP6H/WRcTpZRvcVukwJhBN+f96s/OvR2sAyOXPm5L3b mXLpdbmUgIHNSMDluBc0RN4cSUrzj/YDlPW+GXBPChp5QUawTbA463xv/ltFXEKfWbpp8YAbihz9 YJnaAnwWmxPQFVCGvv1Ns8tcOEQIZIrX60OOg8g8w9xLTPg0nEXC6+im/vE1cYcZbU0/UdrYNK29 drzBGlNd+UwAsgaFOI34xhYNypwov/Kaw9Ri9OGkuERcIUypQV2mWmoX20mbmkuE7KVZgkoAkPP0 ku3I4v41RHbq44WEe8Fq+zdzi5sPaebxlayMqWk5JzfbUSChamgWc4IrOxqNiACWf1+FizIIu1nJ 48PxKoWzxjs4DjSsaNxo2gophzwmdhjy4G1Q9C4snwN8mNPqp/kBCd2/E8d0PDYAiX3qbqStwEDg 3cnPfZsYVWB2vZ/EK1QDOHrHQPyGqk5PatjgnZHxOw/0qgLq0FilBDCrL7hOKUTz0ZtFsffw/Gg7 m07cABaDstdZAz6wgieiGzrn9a2T2dePd9WiP2TxKW1P2sA/6MyWOJHp3N5u69okDU3RuX1GNmSQ 6EmoQHbU1H8CoykI4rraXuAE8Zbh9guwoQdYLDxqc1pRaGNpldgBfyT/U9bb9P+9HDfaR0yvMes8 lyiw4B98NOAm9NUDOhkVmuAnE1Mi8nGr3ONlNhi/3bSN6/pckAnihbmXueKCsD9N5PrCIyLH3baO zzjXf6ATYN Date: Mon, 10 Jan 2022 15:47:02 +0800 From: Conley Lee To: Corentin Labbe Cc: davem@davemloft.net, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] sun4i-emac.c: enable emac tx dma X-OQ-MSGID: References: Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 01/09/22 at 09:45下午, Corentin Labbe wrote: > Date: Sun, 9 Jan 2022 21:45:01 +0100 > From: Corentin Labbe > To: conleylee@foxmail.com > Cc: davem@davemloft.net, mripard@kernel.org, wens@csie.org, > jernej.skrabec@gmail.com, netdev@vger.kernel.org, > linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v1] sun4i-emac.c: enable emac tx dma > > Le Sun, Jan 09, 2022 at 05:17:55PM +0800, conleylee@foxmail.com a écrit : > > From: conley > > > > Hello > > I am reading the R40 user manual and trying to create a new path to enable > > emac tx dma channel. According to the figure 8-21(TX Operation Diagram), > > I try to enable emac tx dma channel by the follow steps: > > 1. enable tx dma mode > > 2. set packet lengths > > 2. move data from skb to tx fifo by using dma in xmit function. > > 3. start transfer from tx fifo to phy in dma tx done callback > > > > But it doesn't work. emac tx interrupt and dma finished interrupt are > > raised, but no packets are transmitted (I test it by tcpdump). > > Do you know how to configure the emac tx dma correctly? Thanks ~ > > > > Hello > > Here are my thoughts to help you: > - Your email is not a real patch, but an ask for help, so you should not use [ PATCH ] in the subject. > - If it was a patch, "v1" is not necessary > - Your patch below is doing too many unrelated different things, it is hard to see the DMA TX enable part > - I think you could first send a preliminary patch which adds all EMAC_INT_CTL_TX_xxx which are already used by the driver (to reduce the diff) > - Without the DTB change, it is hard to see the whole picture, did you correctly use the right dma number for an easy example. > - Knowing also the board (and so PHY, modes etc...) could help > - I think your priority should not to add TX, but to fix reported problems to your initial patch (build warnings/error https://marc.info/?l=linux-arm-kernel&m=164159846213585&w=2) since your work on TX will need to be applied after this. > - For the previous point, always build test with at least 2 different 32/64 arch. And if possible a total different arch (like x86_64). > > Anyway, I will try to test your patch on my a10 board > > Regards Thanks a lot for your help ~ I will submit an patch which add all register related. By the way, the build warnings problems have been fixed by Jakub Kicinski .