From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbdI1K6i (ORCPT ); Thu, 28 Sep 2017 06:58:38 -0400 Received: from terminus.zytor.com ([65.50.211.136]:60455 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868AbdI1K6g (ORCPT ); Thu, 28 Sep 2017 06:58:36 -0400 Date: Thu, 28 Sep 2017 03:54:56 -0700 From: tip-bot for Josh Poimboeuf Message-ID: Cc: linux-kernel@vger.kernel.org, jslaby@suse.cz, peterz@infradead.org, jgross@suse.com, boris.ostrovsky@oracle.com, jpoimboe@redhat.com, hpa@zytor.com, torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, luto@kernel.org Reply-To: hpa@zytor.com, tglx@linutronix.de, torvalds@linux-foundation.org, jgross@suse.com, boris.ostrovsky@oracle.com, jpoimboe@redhat.com, luto@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, jslaby@suse.cz In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:core/objtool] objtool: Don't report end of section error after an empty unwind hint Git-Commit-ID: 00d96180dc38ef872ac471c2d3e14b067cbd895d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 00d96180dc38ef872ac471c2d3e14b067cbd895d Gitweb: https://git.kernel.org/tip/00d96180dc38ef872ac471c2d3e14b067cbd895d Author: Josh Poimboeuf AuthorDate: Mon, 18 Sep 2017 21:43:30 -0500 Committer: Ingo Molnar CommitDate: Thu, 28 Sep 2017 09:39:02 +0200 objtool: Don't report end of section error after an empty unwind hint If asm code specifies an UNWIND_HINT_EMPTY hint, don't warn if the section ends unexpectedly. This can happen with the xen-head.S code because the hypercall_page is "text" but it's all zeros. Signed-off-by: Josh Poimboeuf Cc: Andy Lutomirski Cc: Boris Ostrovsky Cc: Jiri Slaby Cc: Juergen Gross Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/ddafe199dd8797e40e3c2777373347eba1d65572.1505764066.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- tools/objtool/check.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index a0c518e..83f370f 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1752,11 +1752,14 @@ static int validate_branch(struct objtool_file *file, struct instruction *first, if (insn->dead_end) return 0; - insn = next_insn; - if (!insn) { + if (!next_insn) { + if (state.cfa.base == CFI_UNDEFINED) + return 0; WARN("%s: unexpected end of section", sec->name); return 1; } + + insn = next_insn; } return 0;