From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbdLFUgQ (ORCPT ); Wed, 6 Dec 2017 15:36:16 -0500 Received: from terminus.zytor.com ([65.50.211.136]:38543 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbdLFUgN (ORCPT ); Wed, 6 Dec 2017 15:36:13 -0500 Date: Wed, 6 Dec 2017 12:30:44 -0800 From: tip-bot for Dave Young Message-ID: Cc: tglx@linutronix.de, ard.biesheuvel@linaro.org, gregkh@linuxfoundation.org, peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, matt@codeblueprint.co.uk, hpa@zytor.com, dyoung@redhat.com Reply-To: dyoung@redhat.com, hpa@zytor.com, matt@codeblueprint.co.uk, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, gregkh@linuxfoundation.org, ard.biesheuvel@linaro.org, tglx@linutronix.de In-Reply-To: <20171206095010.24170-4-ard.biesheuvel@linaro.org> References: <20171206095010.24170-4-ard.biesheuvel@linaro.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:efi/urgent] efi: Add comment to avoid future expanding of sysfs systab Git-Commit-ID: 0b02e448a2ebb46eb9be4f1bdfc87112bd420cbf X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 0b02e448a2ebb46eb9be4f1bdfc87112bd420cbf Gitweb: https://git.kernel.org/tip/0b02e448a2ebb46eb9be4f1bdfc87112bd420cbf Author: Dave Young AuthorDate: Wed, 6 Dec 2017 09:50:10 +0000 Committer: Ingo Molnar CommitDate: Wed, 6 Dec 2017 19:32:23 +0100 efi: Add comment to avoid future expanding of sysfs systab /sys/firmware/efi/systab shows several different values, it breaks sysfs one file one value design. But since there are already userspace tools depend on it eg. kexec-tools so add code comment to alert future expanding of this file. Signed-off-by: Dave Young Signed-off-by: Ard Biesheuvel Reviewed-by: Greg Kroah-Hartman Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Matt Fleming Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20171206095010.24170-4-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar --- drivers/firmware/efi/efi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index c3eefa1..557a478 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -109,6 +109,8 @@ struct kobject *efi_kobj; /* * Let's not leave out systab information that snuck into * the efivars driver + * Note, do not add more fields in systab sysfs file as it breaks sysfs + * one value per file rule! */ static ssize_t systab_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)