From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304AbdBUIPa (ORCPT ); Tue, 21 Feb 2017 03:15:30 -0500 Received: from terminus.zytor.com ([65.50.211.136]:56232 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdBUIPX (ORCPT ); Tue, 21 Feb 2017 03:15:23 -0500 Date: Tue, 21 Feb 2017 00:14:51 -0800 From: tip-bot for Jiri Olsa Message-ID: Cc: tglx@linutronix.de, a.p.zijlstra@chello.nl, dsahern@gmail.com, namhyung@kernel.org, acme@redhat.com, jolsa@redhat.com, linux-kernel@vger.kernel.org, bp@alien8.de, jolsa@kernel.org, mingo@kernel.org, hpa@zytor.com Reply-To: hpa@zytor.com, mingo@kernel.org, jolsa@kernel.org, bp@alien8.de, linux-kernel@vger.kernel.org, jolsa@redhat.com, acme@redhat.com, namhyung@kernel.org, dsahern@gmail.com, a.p.zijlstra@chello.nl, tglx@linutronix.de In-Reply-To: <20170217170034.GB15389@krava> References: <20170217170034.GB15389@krava> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf stat: Add -a as default target Git-Commit-ID: 0d79f8b93187c771b6971acfaba67f4e2f1e0710 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 0d79f8b93187c771b6971acfaba67f4e2f1e0710 Gitweb: http://git.kernel.org/tip/0d79f8b93187c771b6971acfaba67f4e2f1e0710 Author: Jiri Olsa AuthorDate: Fri, 17 Feb 2017 18:00:34 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 17 Feb 2017 17:31:10 -0300 perf stat: Add -a as default target Boris asked for default -a option in case we monitor only uncore events. While implementing that I thought it might be actually useful to make it overall default. Running 'perf stat' will now collect system wide data. Committer note: Testing it: # perf stat ^C Performance counter stats for 'system wide': 3571.559178 cpu-clock (msec) # 4.000 CPUs utilized 3,346 context-switches # 0.937 K/sec 277 cpu-migrations # 0.078 K/sec 57,271 page-faults # 0.016 M/sec 4,535,633,835 cycles # 1.270 GHz 6,389,736,516 instructions # 1.41 insn per cycle 1,541,293,875 branches # 431.547 M/sec 14,526,396 branch-misses # 0.94% of all branches 0.892950118 seconds time elapsed # Requested-and-Acked-by: Borislav Petkov Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20170217170034.GB15389@krava Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-stat.txt | 2 +- tools/perf/builtin-stat.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt index d96ccd4..aecf2a8 100644 --- a/tools/perf/Documentation/perf-stat.txt +++ b/tools/perf/Documentation/perf-stat.txt @@ -63,7 +63,7 @@ report:: -a:: --all-cpus:: - system-wide collection from all CPUs + system-wide collection from all CPUs (default if no target is specified) -c:: --scale:: diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index ca27a8a..9989b03 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2445,8 +2445,9 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused) } else if (big_num_opt == 0) /* User passed --no-big-num */ big_num = false; + /* Make system wide (-a) the default target. */ if (!argc && target__none(&target)) - usage_with_options(stat_usage, stat_options); + target.system_wide = true; if (run_count < 0) { pr_err("Run count must be a positive number\n");