From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758773AbbDXTEZ (ORCPT ); Fri, 24 Apr 2015 15:04:25 -0400 Received: from terminus.zytor.com ([198.137.202.10]:47550 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757092AbbDXTEW (ORCPT ); Fri, 24 Apr 2015 15:04:22 -0400 Date: Fri, 24 Apr 2015 12:03:36 -0700 From: tip-bot for Viresh Kumar Message-ID: Cc: peterz@infradead.org, mingo@kernel.org, daniel.lezcano@linaro.org, hpa@zytor.com, tglx@linutronix.de, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org Reply-To: daniel.lezcano@linaro.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, tglx@linutronix.de In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/urgent] clockevents: Shutdown detached clockevent device Git-Commit-ID: 149aabcc44e3e2c1f8fe4f0832be53d2db55b598 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 149aabcc44e3e2c1f8fe4f0832be53d2db55b598 Gitweb: http://git.kernel.org/tip/149aabcc44e3e2c1f8fe4f0832be53d2db55b598 Author: Viresh Kumar AuthorDate: Fri, 10 Apr 2015 12:56:41 +0530 Committer: Thomas Gleixner CommitDate: Fri, 24 Apr 2015 21:01:48 +0200 clockevents: Shutdown detached clockevent device A clockevent device is marked DETACHED when it is replaced by another clockevent device. The device is shutdown properly for drivers that implement legacy ->set_mode() callback, as we call ->set_mode() for CLOCK_EVT_MODE_UNUSED as well. But for the new per-state callback interface, we skip shutting down the device, as we thought its an internal state change. That wasn't correct. The effect is that the device is left programmed in oneshot or periodic mode. Fall-back to 'case CLOCK_EVT_STATE_SHUTDOWN', to shutdown the device. Fixes: bd624d75db21 "clockevents: Introduce mode specific callbacks" Reported-by: Daniel Lezcano Signed-off-by: Viresh Kumar Cc: linaro-kernel@lists.linaro.org Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/eef0a91c51b74d4e52c8e5a95eca27b5a0563f07.1428650683.git.viresh.kumar@linaro.org Signed-off-by: Thomas Gleixner --- kernel/time/clockevents.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 25d942d..629be4e 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -117,11 +117,7 @@ static int __clockevents_set_state(struct clock_event_device *dev, /* Transition with new state-specific callbacks */ switch (state) { case CLOCK_EVT_STATE_DETACHED: - /* - * This is an internal state, which is guaranteed to go from - * SHUTDOWN to DETACHED. No driver interaction required. - */ - return 0; + /* The clockevent device is getting replaced. Shut it down. */ case CLOCK_EVT_STATE_SHUTDOWN: return dev->set_state_shutdown(dev);