From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753084AbdHJMMu (ORCPT ); Thu, 10 Aug 2017 08:12:50 -0400 Received: from terminus.zytor.com ([65.50.211.136]:47023 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752580AbdHJMMr (ORCPT ); Thu, 10 Aug 2017 08:12:47 -0400 Date: Thu, 10 Aug 2017 05:09:03 -0700 From: tip-bot for Cheng Jian Message-ID: Cc: akpm@linux-foundation.org, mingo@kernel.org, hpa@zytor.com, xiexiuqi@huawei.com, torvalds@linux-foundation.org, cj.chengjian@huawei.com, huawei.libin@huawei.com, tglx@linutronix.de, peterz@infradead.org, linux-kernel@vger.kernel.org Reply-To: hpa@zytor.com, torvalds@linux-foundation.org, xiexiuqi@huawei.com, akpm@linux-foundation.org, mingo@kernel.org, huawei.libin@huawei.com, tglx@linutronix.de, peterz@infradead.org, linux-kernel@vger.kernel.org, cj.chengjian@huawei.com In-Reply-To: <1501838377-109720-1-git-send-email-cj.chengjian@huawei.com> References: <1501838377-109720-1-git-send-email-cj.chengjian@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/core: Remove unnecessary initialization init_idle_bootup_task() Git-Commit-ID: 18f08dae19990f5fffde92e3a63e0d90cda0f1a8 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 18f08dae19990f5fffde92e3a63e0d90cda0f1a8 Gitweb: http://git.kernel.org/tip/18f08dae19990f5fffde92e3a63e0d90cda0f1a8 Author: Cheng Jian AuthorDate: Fri, 4 Aug 2017 17:19:37 +0800 Committer: Ingo Molnar CommitDate: Thu, 10 Aug 2017 12:18:18 +0200 sched/core: Remove unnecessary initialization init_idle_bootup_task() init_idle_bootup_task( ) is called in rest_init( ) to switch the scheduling class of the boot thread to the idle class. the function only sets: idle->sched_class = &idle_sched_class; which has been set in init_idle() called by sched_init(): /* * The idle tasks have their own, simple scheduling class: */ idle->sched_class = &idle_sched_class; We've already set the boot thread to idle class in start_kernel()->sched_init()->init_idle() so it's unnecessary to set it again in start_kernel()->rest_init()->init_idle_bootup_task() Signed-off-by: Cheng Jian Signed-off-by: Xie XiuQi Signed-off-by: Peter Zijlstra (Intel) Cc: Cc: Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1501838377-109720-1-git-send-email-cj.chengjian@huawei.com Signed-off-by: Ingo Molnar --- include/linux/sched/task.h | 1 - init/main.c | 1 - kernel/sched/core.c | 5 ----- 3 files changed, 7 deletions(-) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index c97e5f0..79a2a74 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -30,7 +30,6 @@ extern int lockdep_tasklist_lock_is_held(void); extern asmlinkage void schedule_tail(struct task_struct *prev); extern void init_idle(struct task_struct *idle, int cpu); -extern void init_idle_bootup_task(struct task_struct *idle); extern int sched_fork(unsigned long clone_flags, struct task_struct *p); extern void sched_dead(struct task_struct *p); diff --git a/init/main.c b/init/main.c index 052481f..881d624 100644 --- a/init/main.c +++ b/init/main.c @@ -430,7 +430,6 @@ static noinline void __ref rest_init(void) * The boot idle thread must execute schedule() * at least once to get things moving: */ - init_idle_bootup_task(current); schedule_preempt_disabled(); /* Call into cpu_idle with preempt disabled */ cpu_startup_entry(CPUHP_ONLINE); diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 835a234..6d91c10 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5177,11 +5177,6 @@ void show_state_filter(unsigned long state_filter) debug_show_all_locks(); } -void init_idle_bootup_task(struct task_struct *idle) -{ - idle->sched_class = &idle_sched_class; -} - /** * init_idle - set up an idle thread for a given CPU * @idle: task in question