From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756345AbcB0Jmq (ORCPT ); Sat, 27 Feb 2016 04:42:46 -0500 Received: from torg.zytor.com ([198.137.202.12]:39234 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754571AbcB0Jmm (ORCPT ); Sat, 27 Feb 2016 04:42:42 -0500 Date: Sat, 27 Feb 2016 01:42:00 -0800 From: tip-bot for Namhyung Kim Message-ID: Cc: wangnan0@huawei.com, tglx@linutronix.de, peterz@infradead.org, dsahern@gmail.com, acme@redhat.com, hpa@zytor.com, eranian@google.com, linux-kernel@vger.kernel.org, jolsa@kernel.org, andi@firstfloor.org, namhyung@kernel.org, mingo@kernel.org Reply-To: hpa@zytor.com, acme@redhat.com, eranian@google.com, jolsa@kernel.org, andi@firstfloor.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, mingo@kernel.org, wangnan0@huawei.com, tglx@linutronix.de, peterz@infradead.org, dsahern@gmail.com In-Reply-To: <1456488800-28124-3-git-send-email-namhyung@kernel.org> References: <1456488800-28124-3-git-send-email-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf hists browser: Cleanup hist_browser__update_percent_limit() Git-Commit-ID: 201fde73b111e7c31fdc0e9fa6bc4b73dfef699d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 201fde73b111e7c31fdc0e9fa6bc4b73dfef699d Gitweb: http://git.kernel.org/tip/201fde73b111e7c31fdc0e9fa6bc4b73dfef699d Author: Namhyung Kim AuthorDate: Fri, 26 Feb 2016 21:13:18 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 26 Feb 2016 11:20:36 -0300 perf hists browser: Cleanup hist_browser__update_percent_limit() The previous patch introduced __rb_hierarchy_next() function with various move direction like HMD_FORCE_CHILD but missed to change using it some place. Signed-off-by: Namhyung Kim Cc: Andi Kleen Cc: David Ahern Cc: Jiri Olsa Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Wang Nan Link: http://lkml.kernel.org/r/1456488800-28124-3-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/hists.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 6bcd767..904eaa7 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -2477,12 +2477,7 @@ static void hist_browser__update_percent_limit(struct hist_browser *hb, min_callchain_hits, &callchain_param); next: - /* - * Tentatively set unfolded so that the rb_hierarchy_next() - * can toggle children of folded entries too. - */ - he->unfolded = he->has_children; - nd = rb_hierarchy_next(nd); + nd = __rb_hierarchy_next(nd, HMD_FORCE_CHILD); /* force to re-evaluate folding state of callchains */ he->init_have_children = false;