From: tip-bot for Jan Kiszka <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, jolsa@kernel.org, jan.kiszka@siemens.com, namhyung@kernel.org, rostedt@goodmis.org, tglx@linutronix.de Subject: [tip:perf/core] tools lib traceevent: Report unknown VMX exit reasons with code Date: Tue, 24 Jun 2014 22:48:43 -0700 [thread overview] Message-ID: <tip-20d3cbd75ef17b96dfb4f5f1600c0278d330f5ca@git.kernel.org> (raw) In-Reply-To: <5207446F.1090703@web.de> Commit-ID: 20d3cbd75ef17b96dfb4f5f1600c0278d330f5ca Gitweb: http://git.kernel.org/tip/20d3cbd75ef17b96dfb4f5f1600c0278d330f5ca Author: Jan Kiszka <jan.kiszka@siemens.com> AuthorDate: Thu, 12 Jun 2014 22:10:03 -0400 Committer: Jiri Olsa <jolsa@kernel.org> CommitDate: Thu, 19 Jun 2014 18:17:54 +0200 tools lib traceevent: Report unknown VMX exit reasons with code Allows to parse the result even if the KVM plugin does not yet understand a specific exit code. Link: http://lkml.kernel.org/r/5207446F.1090703@web.de Acked-by: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/lib/traceevent/plugin_kvm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/lib/traceevent/plugin_kvm.c b/tools/lib/traceevent/plugin_kvm.c index 9e0e8c6..3e61220 100644 --- a/tools/lib/traceevent/plugin_kvm.c +++ b/tools/lib/traceevent/plugin_kvm.c @@ -240,9 +240,8 @@ static const char *find_exit_reason(unsigned isa, int val) for (i = 0; strings[i].val >= 0; i++) if (strings[i].val == val) break; - if (strings[i].str) - return strings[i].str; - return "UNKNOWN"; + + return strings[i].str; } static int kvm_exit_handler(struct trace_seq *s, struct pevent_record *record, @@ -251,6 +250,7 @@ static int kvm_exit_handler(struct trace_seq *s, struct pevent_record *record, unsigned long long isa; unsigned long long val; unsigned long long info1 = 0, info2 = 0; + const char *reason; if (pevent_get_field_val(s, event, "exit_reason", record, &val, 1) < 0) return -1; @@ -258,7 +258,11 @@ static int kvm_exit_handler(struct trace_seq *s, struct pevent_record *record, if (pevent_get_field_val(s, event, "isa", record, &isa, 0) < 0) isa = 1; - trace_seq_printf(s, "reason %s", find_exit_reason(isa, val)); + reason = find_exit_reason(isa, val); + if (reason) + trace_seq_printf(s, "reason %s", reason); + else + trace_seq_printf(s, "reason UNKNOWN (%llu)", val); pevent_print_num_field(s, " rip 0x%lx", event, "guest_rip", record, 1);
prev parent reply other threads:[~2014-06-25 5:49 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-08-11 7:59 [PATCH] trace-cmd: " Jan Kiszka 2013-10-04 13:40 ` Jan Kiszka 2013-10-04 14:50 ` Steven Rostedt 2014-06-25 5:48 ` tip-bot for Jan Kiszka [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tip-20d3cbd75ef17b96dfb4f5f1600c0278d330f5ca@git.kernel.org \ --to=tipbot@zytor.com \ --cc=hpa@zytor.com \ --cc=jan.kiszka@siemens.com \ --cc=jolsa@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=namhyung@kernel.org \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --subject='Re: [tip:perf/core] tools lib traceevent: Report unknown VMX exit reasons with code' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.