All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Toshi Kani <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: brgerst@gmail.com, elliott@hpe.com, luto@amacapital.net,
	bp@suse.de, jgross@suse.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, dvlasenk@redhat.com,
	peterz@infradead.org, toshi.kani@hp.com, toshi.kani@hpe.com,
	mingo@kernel.org, hpa@zytor.com, bp@alien8.de,
	torvalds@linux-foundation.org, mcgrof@suse.com,
	tglx@linutronix.de
Subject: [tip:x86/mm] x86/mm/pat: Add pat_disable() interface
Date: Tue, 29 Mar 2016 03:38:24 -0700	[thread overview]
Message-ID: <tip-224bb1e5d67ba0f2872c98002d6a6f991ac6fd4a@git.kernel.org> (raw)
In-Reply-To: <1458769323-24491-3-git-send-email-toshi.kani@hpe.com>

Commit-ID:  224bb1e5d67ba0f2872c98002d6a6f991ac6fd4a
Gitweb:     http://git.kernel.org/tip/224bb1e5d67ba0f2872c98002d6a6f991ac6fd4a
Author:     Toshi Kani <toshi.kani@hpe.com>
AuthorDate: Wed, 23 Mar 2016 15:41:58 -0600
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 29 Mar 2016 12:23:25 +0200

x86/mm/pat: Add pat_disable() interface

In preparation for fixing a regression caused by:

  9cd25aac1f44 ("x86/mm/pat: Emulate PAT when it is disabled")

... PAT needs to provide an interface that prevents the OS from
initializing the PAT MSR.

PAT MSR initialization must be done on all CPUs using the specific
sequence of operations defined in the Intel SDM.  This requires MTRRs
to be enabled since pat_init() is called as part of MTRR init
from mtrr_rendezvous_handler().

Make pat_disable() as the interface that prevents the OS from
initializing the PAT MSR.  MTRR will call this interface when it
cannot provide the SDM-defined sequence to initialize PAT.

This also assures that pat_disable() called from pat_bsp_init()
will set the PAT table properly when CPU does not support PAT.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Borislav Petkov <bp@suse.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Luis R. Rodriguez <mcgrof@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Elliott <elliott@hpe.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: konrad.wilk@oracle.com
Cc: paul.gortmaker@windriver.com
Cc: xen-devel@lists.xenproject.org
Link: http://lkml.kernel.org/r/1458769323-24491-3-git-send-email-toshi.kani@hpe.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/asm/pat.h |  1 +
 arch/x86/mm/pat.c          | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/pat.h b/arch/x86/include/asm/pat.h
index 97ea55b..0ad356c 100644
--- a/arch/x86/include/asm/pat.h
+++ b/arch/x86/include/asm/pat.h
@@ -5,6 +5,7 @@
 #include <asm/pgtable_types.h>
 
 bool pat_enabled(void);
+void pat_disable(const char *reason);
 extern void pat_init(void);
 void __init_cache_modes(u64);
 
diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index b4663885..1cc1d37 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -40,11 +40,22 @@
 static bool boot_cpu_done;
 
 static int __read_mostly __pat_enabled = IS_ENABLED(CONFIG_X86_PAT);
+static void init_cache_modes(void);
 
-static inline void pat_disable(const char *reason)
+void pat_disable(const char *reason)
 {
+	if (!__pat_enabled)
+		return;
+
+	if (boot_cpu_done) {
+		WARN_ONCE(1, "x86/PAT: PAT cannot be disabled after initialization\n");
+		return;
+	}
+
 	__pat_enabled = 0;
 	pr_info("x86/PAT: %s\n", reason);
+
+	init_cache_modes();
 }
 
 static int __init nopat(char *str)

  reply	other threads:[~2016-03-29 10:39 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 21:41 [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes Toshi Kani
2016-03-23 21:41 ` [PATCH v3 1/7] x86/mm/pat: Add support of non-default PAT MSR setting Toshi Kani
2016-03-29 10:37   ` [tip:x86/mm] " tip-bot for Toshi Kani
2016-03-23 21:41 ` [PATCH v3 1/7] " Toshi Kani
2016-03-23 21:41 ` [PATCH v3 2/7] x86/mm/pat: Add pat_disable() interface Toshi Kani
2016-03-23 21:41   ` Toshi Kani
2016-03-29 10:38   ` tip-bot for Toshi Kani [this message]
2016-03-23 21:41 ` [PATCH v3 3/7] x86/mm/pat: Replace cpu_has_pat with boot_cpu_has Toshi Kani
2016-03-29 10:38   ` [tip:x86/mm] x86/mm/pat: Replace cpu_has_pat with boot_cpu_has() tip-bot for Toshi Kani
2016-03-23 21:41 ` [PATCH v3 3/7] x86/mm/pat: Replace cpu_has_pat with boot_cpu_has Toshi Kani
2016-03-23 21:42 ` [PATCH v3 4/6] x86/mtrr: Fix Xorg crashes in Qemu sessions Toshi Kani
2016-03-23 21:42   ` Toshi Kani
2016-03-29 10:39   ` [tip:x86/mm] " tip-bot for Toshi Kani
2016-03-23 21:42 ` [PATCH v3 5/7] x86/mtrr: Fix PAT init handling when MTRR is disabled Toshi Kani
2016-03-29 10:39   ` [tip:x86/mm] " tip-bot for Toshi Kani
2016-03-23 21:42 ` [PATCH v3 5/7] " Toshi Kani
2016-03-23 21:42 ` [PATCH v3 6/7] x86/xen,pat: Remove PAT table init code from Xen Toshi Kani
2016-03-23 21:42   ` [PATCH v3 6/7] x86/xen, pat: " Toshi Kani
2016-03-29 10:39   ` [tip:x86/mm] " tip-bot for Toshi Kani
2016-03-23 21:42 ` [PATCH v3 7/7] x86/pat: Document PAT initialization Toshi Kani
2016-03-23 21:42 ` Toshi Kani
2016-03-29 10:40   ` [tip:x86/mm] x86/pat: Document the PAT initialization sequence tip-bot for Toshi Kani
2016-03-29 10:34 ` [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes Ingo Molnar
2016-03-29 14:19   ` Toshi Kani
2016-03-29 14:19   ` Toshi Kani
2016-03-29 14:46     ` Boris Ostrovsky
2016-03-29 14:46     ` [Xen-devel] " Boris Ostrovsky
2016-03-29 15:49       ` Toshi Kani
2016-03-29 15:49       ` [Xen-devel] " Toshi Kani
2016-03-30 18:02         ` Luis R. Rodriguez
2016-03-30 18:02           ` Luis R. Rodriguez
2016-03-30 18:58           ` Konrad Rzeszutek Wilk
2016-03-30 18:58             ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-03-30 20:10             ` [LKP] " Luis R. Rodriguez
2016-03-30 20:10             ` [LKP] [Xen-devel] " Luis R. Rodriguez
2016-03-30 20:10               ` Luis R. Rodriguez
2016-03-30 20:29               ` [LKP] " Konrad Rzeszutek Wilk
2016-03-30 20:29                 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-03-30 20:47                 ` [LKP] " Luis R. Rodriguez
2016-03-30 20:47                 ` [LKP] [Xen-devel] " Luis R. Rodriguez
2016-03-30 20:47                   ` Luis R. Rodriguez
2016-03-30 18:02         ` Luis R. Rodriguez
2016-03-29 10:34 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-224bb1e5d67ba0f2872c98002d6a6f991ac6fd4a@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=bp@suse.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=elliott@hpe.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mcgrof@suse.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=toshi.kani@hp.com \
    --cc=toshi.kani@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.