All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Christoffer Dall <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, eric.auger@redhat.com,
	catalin.marinas@arm.com, hpa@zytor.com, cdall@linaro.org,
	marc.zyngier@arm.com, mingo@kernel.org, will.deacon@arm.com,
	linux-kernel@vger.kernel.org
Subject: [tip:irq/core] genirq: Document vcpu_info usage for percpu_devid interrupts
Date: Sun, 29 Oct 2017 08:22:04 -0700	[thread overview]
Message-ID: <tip-250a53d6fcd86012935d1cf71eb2e3d6e88c412c@git.kernel.org> (raw)
In-Reply-To: <1509093281-15225-13-git-send-email-cdall@linaro.org>

Commit-ID:  250a53d6fcd86012935d1cf71eb2e3d6e88c412c
Gitweb:     https://git.kernel.org/tip/250a53d6fcd86012935d1cf71eb2e3d6e88c412c
Author:     Christoffer Dall <cdall@linaro.org>
AuthorDate: Fri, 27 Oct 2017 10:34:33 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 29 Oct 2017 16:18:37 +0100

genirq: Document vcpu_info usage for percpu_devid interrupts

It is currently unclear how to set the VCPU affinity for a percpu_devid
interrupt , since the Linux irq_data structure describes the state for
multiple interrupts, one for each physical CPU on the system.  Since
each such interrupt can be associated with different VCPUs or none at
all, associating a single VCPU state with such an interrupt does not
capture the necessary semantics.

The implementers of irq_set_affinity are the Intel and AMD IOMMUs, and
the ARM GIC irqchip.  The Intel and AMD callers do not appear to use
percpu_devid interrupts, and the ARM GIC implementation only checks the
pointer against NULL vs. non-NULL.

Therefore, simply update the function documentation to explain the
expected use in the context of percpu_devid interrupts, allowing future
changes or additions to irqchip implementers to do the right thing.

Signed-off-by: Christoffer Dall <cdall@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: kvm@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Eric Auger <eric.auger@redhat.com>
Cc: kvmarm@lists.cs.columbia.edu
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lkml.kernel.org/r/1509093281-15225-13-git-send-email-cdall@linaro.org
---
 kernel/irq/manage.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index e667912..c65f282 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -381,7 +381,8 @@ int irq_select_affinity_usr(unsigned int irq)
 /**
  *	irq_set_vcpu_affinity - Set vcpu affinity for the interrupt
  *	@irq: interrupt number to set affinity
- *	@vcpu_info: vCPU specific data
+ *	@vcpu_info: vCPU specific data or pointer to a percpu array of vCPU
+ *	            specific data for percpu_devid interrupts
  *
  *	This function uses the vCPU specific data to set the vCPU
  *	affinity for an irq. The vCPU specific data is passed from

  reply	other threads:[~2017-10-29 15:24 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  8:34 [PATCH v5 00/20] KVM: arm/arm64: Optimize arch timer register handling Christoffer Dall
2017-10-27  8:34 ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 01/20] irqchip/gic: Deal with broken firmware exposing only 4kB of GICv2 CPU interface Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 02/20] arm64: Implement arch_counter_get_cntpct to read the physical counter Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27 10:53   ` Catalin Marinas
2017-10-27 10:53     ` Catalin Marinas
2017-10-29  1:51     ` Christoffer Dall
2017-10-29  1:51       ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 03/20] arm64: Use physical counter for in-kernel reads when booted in EL2 Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27 10:53   ` Catalin Marinas
2017-10-27 10:53     ` Catalin Marinas
2017-10-27  8:34 ` [PATCH v5 04/20] KVM: arm/arm64: Guard kvm_vgic_map_is_active against !vgic_initialized Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-11-16 12:29   ` Andre Przywara
2017-11-16 12:29     ` Andre Przywara
2017-11-20 11:20     ` Christoffer Dall
2017-11-20 11:20       ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 05/20] KVM: arm/arm64: Support calling vgic_update_irq_pending from irq context Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 06/20] KVM: arm/arm64: Check that system supports split eoi/deactivate Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 07/20] KVM: arm/arm64: Make timer_arm and timer_disarm helpers more generic Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 08/20] KVM: arm/arm64: Rename soft timer to bg_timer Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 09/20] KVM: arm/arm64: Move timer/vgic flush/sync under disabled irq Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 10/20] KVM: arm/arm64: Use separate timer for phys timer emulation Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 11/20] KVM: arm/arm64: Move timer save/restore out of the hyp code Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 12/20] genirq: Document vcpu_info usage for percpu_devid interrupts Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-29 15:22   ` tip-bot for Christoffer Dall [this message]
2017-10-27  8:34 ` [PATCH v5 13/20] KVM: arm/arm64: Set VCPU affinity for virt timer irq Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 14/20] KVM: arm/arm64: Avoid timer save/restore in vcpu entry/exit Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 15/20] KVM: arm/arm64: Support EL1 phys timer register access in set/get reg Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 16/20] KVM: arm/arm64: Use kvm_arm_timer_set/get_reg for guest register traps Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 17/20] KVM: arm/arm64: Move phys_timer_emulate function Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 18/20] KVM: arm/arm64: Avoid phys timer emulation in vcpu entry/exit Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-27  8:34 ` [PATCH v5 19/20] KVM: arm/arm64: Get rid of kvm_timer_flush_hwstate Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-11-27 16:50   ` Andrew Jones
2017-11-27 16:50     ` Andrew Jones
2017-11-29 17:39     ` Christoffer Dall
2017-11-29 17:39       ` Christoffer Dall
2017-11-29 18:17       ` Andrew Jones
2017-11-29 18:17         ` Andrew Jones
2017-10-27  8:34 ` [PATCH v5 20/20] KVM: arm/arm64: Rework kvm_timer_should_fire Christoffer Dall
2017-10-27  8:34   ` Christoffer Dall
2017-10-29  1:48 ` [PATCH v5 21/20] arm/arm64: KVM: Load the timer state when enabling the timer Christoffer Dall
2017-10-29  1:48   ` Christoffer Dall
2017-10-29  2:07   ` Marc Zyngier
2017-10-29  2:07     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-250a53d6fcd86012935d1cf71eb2e3d6e88c412c@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=catalin.marinas@arm.com \
    --cc=cdall@linaro.org \
    --cc=eric.auger@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.