From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966168AbbLRIsU (ORCPT ); Fri, 18 Dec 2015 03:48:20 -0500 Received: from terminus.zytor.com ([198.137.202.10]:51790 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964917AbbLRIsQ (ORCPT ); Fri, 18 Dec 2015 03:48:16 -0500 Date: Fri, 18 Dec 2015 00:47:34 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: hpa@zytor.com, jpoimboe@redhat.com, jolsa@kernel.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, tglx@linutronix.de, mingo@kernel.org Reply-To: jolsa@kernel.org, jpoimboe@redhat.com, hpa@zytor.com, peterz@infradead.org, acme@redhat.com, tglx@linutronix.de, mingo@kernel.org, namhyung@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <554a05c18af564ba015c9e68f25730126e0f4acb.1449965119.git.jpoimboe@redhat.com> References: <554a05c18af564ba015c9e68f25730126e0f4acb.1449965119.git.jpoimboe@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf build: Remove unnecessary line in Makefile.feature Git-Commit-ID: 26bc9b2df1f38536cdfd58df94bf8b5601eb894a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 26bc9b2df1f38536cdfd58df94bf8b5601eb894a Gitweb: http://git.kernel.org/tip/26bc9b2df1f38536cdfd58df94bf8b5601eb894a Author: Josh Poimboeuf AuthorDate: Sun, 13 Dec 2015 22:18:01 -0600 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 14 Dec 2015 12:16:15 -0300 perf build: Remove unnecessary line in Makefile.feature This line always silently fails because it doesn't add the 'test-' prefix to the .bin file. And it seems to be unnecessary anyway: the line immediately after it does all the individual feature checks. Signed-off-by: Josh Poimboeuf Acked-by: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/554a05c18af564ba015c9e68f25730126e0f4acb.1449965119.git.jpoimboe@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/build/Makefile.feature | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature index 37ff4c9..b8c31ec 100644 --- a/tools/build/Makefile.feature +++ b/tools/build/Makefile.feature @@ -101,7 +101,6 @@ ifeq ($(feature-all), 1) # $(foreach feat,$(FEATURE_TESTS),$(call feature_set,$(feat))) else - $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS)" LDFLAGS=$(LDFLAGS) -i -j -C $(feature_dir) $(addsuffix .bin,$(FEATURE_TESTS)) >/dev/null 2>&1) $(foreach feat,$(FEATURE_TESTS),$(call feature_check,$(feat))) endif