From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753452AbcGSH0j (ORCPT ); Tue, 19 Jul 2016 03:26:39 -0400 Received: from terminus.zytor.com ([198.137.202.10]:46296 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982AbcGSH0f (ORCPT ); Tue, 19 Jul 2016 03:26:35 -0400 Date: Tue, 19 Jul 2016 00:25:54 -0700 From: tip-bot for Sebastian Andrzej Siewior Message-ID: Cc: bigeasy@linutronix.de, will.deacon@arm.com, ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, shengjiu.wang@freescale.com, anna-maria@linutronix.de, catalin.marinas@arm.com, jszhang@marvell.com, peterz@infradead.org, tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org, james.morse@arm.com Reply-To: anna-maria@linutronix.de, shengjiu.wang@freescale.com, jszhang@marvell.com, catalin.marinas@arm.com, hpa@zytor.com, peterz@infradead.org, tglx@linutronix.de, mingo@kernel.org, james.morse@arm.com, will.deacon@arm.com, bigeasy@linutronix.de, ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org In-Reply-To: <20160713153337.311115906@linutronix.de> References: <20160713153337.311115906@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:smp/hotplug] arm64/armv8 deprecated: Convert to hotplug state machine Git-Commit-ID: 27c01a8c73e15b2135b96a1866e1dbeb797e4806 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 27c01a8c73e15b2135b96a1866e1dbeb797e4806 Gitweb: http://git.kernel.org/tip/27c01a8c73e15b2135b96a1866e1dbeb797e4806 Author: Sebastian Andrzej Siewior AuthorDate: Wed, 13 Jul 2016 17:16:56 +0000 Committer: Ingo Molnar CommitDate: Fri, 15 Jul 2016 10:40:30 +0200 arm64/armv8 deprecated: Convert to hotplug state machine Install the callbacks via the state machine. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Anna-Maria Gleixner Cc: Ard Biesheuvel Cc: Catalin Marinas Cc: James Morse Cc: Jisheng Zhang Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Shengjiu Wang Cc: Thomas Gleixner Cc: Will Deacon Cc: linux-arm-kernel@lists.infradead.org Cc: rt@linutronix.de Link: http://lkml.kernel.org/r/20160713153337.311115906@linutronix.de Signed-off-by: Ingo Molnar --- arch/arm64/kernel/armv8_deprecated.c | 22 +++++----------------- include/linux/cpuhotplug.h | 1 + 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c index c37202c..9668c23 100644 --- a/arch/arm64/kernel/armv8_deprecated.c +++ b/arch/arm64/kernel/armv8_deprecated.c @@ -121,7 +121,7 @@ static int run_all_cpu_set_hw_mode(struct insn_emulation *insn, bool enable) * 0 - If all the hooks ran successfully. * -EINVAL - At least one hook is not supported by the CPU. */ -static int run_all_insn_set_hw_mode(unsigned long cpu) +static int run_all_insn_set_hw_mode(unsigned int cpu) { int rc = 0; unsigned long flags; @@ -131,7 +131,7 @@ static int run_all_insn_set_hw_mode(unsigned long cpu) list_for_each_entry(insn, &insn_emulation, node) { bool enable = (insn->current_mode == INSN_HW); if (insn->ops->set_hw_mode && insn->ops->set_hw_mode(enable)) { - pr_warn("CPU[%ld] cannot support the emulation of %s", + pr_warn("CPU[%u] cannot support the emulation of %s", cpu, insn->ops->name); rc = -EINVAL; } @@ -617,20 +617,6 @@ static struct insn_emulation_ops setend_ops = { .set_hw_mode = setend_set_hw_mode, }; -static int insn_cpu_hotplug_notify(struct notifier_block *b, - unsigned long action, void *hcpu) -{ - int rc = 0; - if ((action & ~CPU_TASKS_FROZEN) == CPU_STARTING) - rc = run_all_insn_set_hw_mode((unsigned long)hcpu); - - return notifier_from_errno(rc); -} - -static struct notifier_block insn_cpu_hotplug_notifier = { - .notifier_call = insn_cpu_hotplug_notify, -}; - /* * Invoked as late_initcall, since not needed before init spawned. */ @@ -649,7 +635,9 @@ static int __init armv8_deprecated_init(void) pr_info("setend instruction emulation is not supported on the system"); } - register_cpu_notifier(&insn_cpu_hotplug_notifier); + cpuhp_setup_state_nocalls(CPUHP_AP_ARM64_ISNDEP_STARTING, + "AP_ARM64_ISNDEP_STARTING", + run_all_insn_set_hw_mode, NULL); register_insn_emulation_sysctl(ctl_abi); return 0; diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index 6cede62..c5b96d0 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -51,6 +51,7 @@ enum cpuhp_state { CPUHP_AP_ARM_XEN_STARTING, CPUHP_AP_ARM_CORESIGHT_STARTING, CPUHP_AP_ARM_CORESIGHT4_STARTING, + CPUHP_AP_ARM64_ISNDEP_STARTING, CPUHP_AP_LEDTRIG_STARTING, CPUHP_AP_NOTIFY_STARTING, CPUHP_AP_ONLINE,