From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: a.p.zijlstra@chello.nl, rostedt@goodmis.org, mingo@kernel.org,
namhyung@kernel.org, dsahern@gmail.com, acme@redhat.com,
js1304@gmail.com, hpa@zytor.com, jolsa@redhat.com,
linux-kernel@vger.kernel.org, minchan@kernel.org,
tglx@linutronix.de
Subject: [tip:perf/core] tools lib traceevent: Honor operator priority
Date: Wed, 8 Apr 2015 08:11:04 -0700 [thread overview]
Message-ID: <tip-3201f0dc42f7fad9387afc4692cea3d0c730cba2@git.kernel.org> (raw)
In-Reply-To: <1428298576-9785-10-git-send-email-namhyung@kernel.org>
Commit-ID: 3201f0dc42f7fad9387afc4692cea3d0c730cba2
Gitweb: http://git.kernel.org/tip/3201f0dc42f7fad9387afc4692cea3d0c730cba2
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Mon, 6 Apr 2015 14:36:16 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 8 Apr 2015 09:07:09 -0300
tools lib traceevent: Honor operator priority
Currently it ignores operator priority and just sets processed args as a
right operand. But it could result in priority inversion in case that
the right operand is also a operator arg and its priority is lower.
For example, following print format is from new kmem events.
"page=%p", REC->pfn != -1UL ? (((struct page *)(0xffffea0000000000UL)) + (REC->pfn)) : ((void *)0)
But this was treated as below:
REC->pfn != ((null - 1UL) ? ((struct page *)0xffffea0000000000UL + REC->pfn) : (void *) 0)
In this case, the right arg was '?' operator which has lower priority.
But it just sets the whole arg so making the output confusing - page was
always 0 or 1 since that's the result of logical operation.
With this patch, it can handle it properly like following:
((REC->pfn != (null - 1UL)) ? ((struct page *)0xffffea0000000000UL + REC->pfn) : (void *) 0)
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Joonsoo Kim <js1304@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/1428298576-9785-10-git-send-email-namhyung@kernel.org
[ Replaced 'swap' with 'rotate' in a comment as requested by Steve and agreed by Namhyung ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/traceevent/event-parse.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 6d31b64..12a7e2a 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -1939,7 +1939,22 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok)
goto out_warn_free;
type = process_arg_token(event, right, tok, type);
- arg->op.right = right;
+
+ if (right->type == PRINT_OP &&
+ get_op_prio(arg->op.op) < get_op_prio(right->op.op)) {
+ struct print_arg tmp;
+
+ /* rotate ops according to the priority */
+ arg->op.right = right->op.left;
+
+ tmp = *arg;
+ *arg = *right;
+ *right = tmp;
+
+ arg->op.left = right;
+ } else {
+ arg->op.right = right;
+ }
} else if (strcmp(token, "[") == 0) {
next prev parent reply other threads:[~2015-04-08 15:11 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 5:36 [PATCHSET 0/9] perf kmem: Implement page allocation analysis (v6) Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-06 5:36 ` [PATCH 1/9] perf kmem: Respect -i option Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-08 15:11 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-04-06 5:36 ` [PATCH 2/9] tracing, mm: Record pfn instead of pointer to struct page Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-14 12:16 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2015-04-06 5:36 ` [PATCH 3/9] perf kmem: Analyze page allocator events also Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-10 21:06 ` Arnaldo Carvalho de Melo
2015-04-10 21:06 ` Arnaldo Carvalho de Melo
2015-04-10 21:10 ` Arnaldo Carvalho de Melo
2015-04-10 21:10 ` Arnaldo Carvalho de Melo
2015-04-13 6:59 ` Namhyung Kim
2015-04-13 6:59 ` Namhyung Kim
2015-04-13 13:21 ` Arnaldo Carvalho de Melo
2015-04-13 13:21 ` Arnaldo Carvalho de Melo
2015-04-13 13:40 ` Arnaldo Carvalho de Melo
2015-04-13 13:40 ` Arnaldo Carvalho de Melo
2015-04-14 12:17 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2015-04-06 5:36 ` [PATCH 4/9] perf kmem: Implement stat --page --caller Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-13 13:40 ` Arnaldo Carvalho de Melo
2015-04-13 13:40 ` Arnaldo Carvalho de Melo
2015-04-14 2:17 ` Namhyung Kim
2015-04-14 2:17 ` Namhyung Kim
2015-04-06 5:36 ` [PATCH 5/9] perf kmem: Support sort keys on page analysis Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-06 5:36 ` [PATCH 6/9] perf kmem: Add --live option for current allocation stat Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-06 5:36 ` [PATCH 7/9] perf kmem: Print gfp flags in human readable string Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-06 5:36 ` [PATCH 8/9] perf kmem: Add kmem.default config option Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-06 5:36 ` [PATCH 9/9] tools lib traceevent: Honor operator priority Namhyung Kim
2015-04-06 5:36 ` Namhyung Kim
2015-04-06 14:45 ` Steven Rostedt
2015-04-06 14:45 ` Steven Rostedt
2015-04-07 7:52 ` Namhyung Kim
2015-04-07 7:52 ` Namhyung Kim
2015-04-07 13:02 ` Arnaldo Carvalho de Melo
2015-04-07 13:02 ` Arnaldo Carvalho de Melo
2015-04-07 13:57 ` Steven Rostedt
2015-04-07 13:57 ` Steven Rostedt
2015-04-07 14:10 ` Namhyung Kim
2015-04-07 14:10 ` Namhyung Kim
2015-04-08 15:11 ` tip-bot for Namhyung Kim [this message]
2015-04-13 13:41 ` Arnaldo Carvalho de Melo
2015-04-13 13:41 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3201f0dc42f7fad9387afc4692cea3d0c730cba2@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.