From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756282AbcA3I0A (ORCPT ); Sat, 30 Jan 2016 03:26:00 -0500 Received: from terminus.zytor.com ([198.137.202.10]:36698 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756102AbcA3IZ5 (ORCPT ); Sat, 30 Jan 2016 03:25:57 -0500 Date: Sat, 30 Jan 2016 00:25:39 -0800 From: tip-bot for Jiri Olsa Message-ID: Cc: mgorman@techsingularity.net, tglx@linutronix.de, mingo@kernel.org, a.p.zijlstra@chello.nl, acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com, namhyung@kernel.org, dsahern@gmail.com, jolsa@kernel.org Reply-To: dsahern@gmail.com, namhyung@kernel.org, jolsa@kernel.org, hpa@zytor.com, acme@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, a.p.zijlstra@chello.nl, mgorman@techsingularity.net In-Reply-To: <1453290995-18485-4-git-send-email-jolsa@kernel.org> References: <1453290995-18485-4-git-send-email-jolsa@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf stat: Do not clean event's private stats Git-Commit-ID: 3f416f22d1e21709a631189ba169f76fd267b374 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 3f416f22d1e21709a631189ba169f76fd267b374 Gitweb: http://git.kernel.org/tip/3f416f22d1e21709a631189ba169f76fd267b374 Author: Jiri Olsa AuthorDate: Wed, 20 Jan 2016 12:56:34 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 26 Jan 2016 11:15:11 -0300 perf stat: Do not clean event's private stats Mel reported stddev reporting was broken due to following commit: 106a94a0f8c2 ("perf stat: Introduce read_counters function") This commit merged interval and overall counters reading into single read_counters function. The old interval code cleaned the stddev data for some reason (it's never displayed in interval mode) and the mentioned commit kept on cleaning the stddev data in merged function, which resulted in the stddev not being displayed. Removing the wrong stddev data cleanup init_stats call. Reported-and-Tested-by: Mel Gorman Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: stable@vger.kernel.org # v4.2+ Fixes: 106a94a0f8c2 ("perf stat: Introduce read_counters function") Link: http://lkml.kernel.org/r/1453290995-18485-4-git-send-email-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/stat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c index 2f901d1..2b58edc 100644 --- a/tools/perf/util/stat.c +++ b/tools/perf/util/stat.c @@ -310,7 +310,6 @@ int perf_stat_process_counter(struct perf_stat_config *config, int i, ret; aggr->val = aggr->ena = aggr->run = 0; - init_stats(ps->res_stats); if (counter->per_pkg) zero_per_pkg(counter);