From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754095AbdAZPft (ORCPT ); Thu, 26 Jan 2017 10:35:49 -0500 Received: from terminus.zytor.com ([65.50.211.136]:47810 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753367AbdAZPbQ (ORCPT ); Thu, 26 Jan 2017 10:31:16 -0500 Date: Thu, 26 Jan 2017 07:28:39 -0800 From: tip-bot for Markus Elfring Message-ID: Cc: wangnan0@huawei.com, ravi.bangoria@linux.vnet.ibm.com, acme@redhat.com, peterz@infradead.org, hekuang@huawei.com, alexander.shishkin@linux.intel.com, mingo@kernel.org, milian.wolff@kdab.com, elfring@users.sourceforge.net, mhiramat@kernel.org, hpa@zytor.com, adrian.hunter@intel.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de Reply-To: jolsa@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, elfring@users.sourceforge.net, milian.wolff@kdab.com, mhiramat@kernel.org, hpa@zytor.com, mingo@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, ravi.bangoria@linux.vnet.ibm.com, peterz@infradead.org, acme@redhat.com, hekuang@huawei.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf probe: Delete an unnecessary check in try_to_find_absolute_address() Git-Commit-ID: 42e233cacc052bd545417c68155f2b9abd1bab72 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 42e233cacc052bd545417c68155f2b9abd1bab72 Gitweb: http://git.kernel.org/tip/42e233cacc052bd545417c68155f2b9abd1bab72 Author: Markus Elfring AuthorDate: Mon, 23 Jan 2017 14:54:26 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 26 Jan 2017 11:42:55 -0300 perf probe: Delete an unnecessary check in try_to_find_absolute_address() Remove a condition check which is unnecessary at the end because this source code place should usually only be reached with a non-zero pointer. Signed-off-by: Markus Elfring Acked-by: Masami Hiramatsu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: He Kuang Cc: Jiri Olsa Cc: Milian Wolff Cc: Peter Zijlstra Cc: Ravi Bangoria Cc: Wang Nan Cc: kernel-janitors@vger.kernel.org Link: http://lkml.kernel.org/r/a3f2473b-6383-a326-bce0-b826423608b8@users.sourceforge.net Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/probe-event.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 4a57c8a..cdfc468 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -3004,10 +3004,8 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev, return 1; errout: - if (*tevs) { - clear_probe_trace_events(*tevs, 1); - *tevs = NULL; - } + clear_probe_trace_events(*tevs, 1); + *tevs = NULL; return err; }