From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932451AbeBLBdT (ORCPT ); Sun, 11 Feb 2018 20:33:19 -0500 Received: from [198.137.202.136] ([198.137.202.136]:34505 "EHLO terminus.zytor.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932335AbeBLBdS (ORCPT ); Sun, 11 Feb 2018 20:33:18 -0500 Date: Sun, 11 Feb 2018 04:13:55 -0800 From: tip-bot for Dominik Brodowski Message-ID: Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, hpa@zytor.com, linux@dominikbrodowski.net, luto@kernel.org, dsafonov@virtuozzo.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org Reply-To: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, hpa@zytor.com, linux@dominikbrodowski.net, luto@kernel.org, dsafonov@virtuozzo.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org In-Reply-To: <20180211111013.16888-4-linux@dominikbrodowski.net> References: <20180211111013.16888-4-linux@dominikbrodowski.net> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] selftests/x86: Do not rely on "int $0x80" in test_mremap_vdso.c Git-Commit-ID: 484790d9ab02704c569d8c7205c630c08eee7822 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 484790d9ab02704c569d8c7205c630c08eee7822 Gitweb: https://git.kernel.org/tip/484790d9ab02704c569d8c7205c630c08eee7822 Author: Dominik Brodowski AuthorDate: Sun, 11 Feb 2018 12:10:11 +0100 Committer: Ingo Molnar CommitDate: Sun, 11 Feb 2018 12:24:47 +0100 selftests/x86: Do not rely on "int $0x80" in test_mremap_vdso.c On 64-bit builds, we should not rely on "int $0x80" working (it only does if CONFIG_IA32_EMULATION=y is enabled). Without this patch, the move test may succeed, but the "int $0x80" causes a segfault, resulting in a false negative output of this self-test. Signed-off-by: Dominik Brodowski Cc: Andy Lutomirski Cc: Dmitry Safonov Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-kselftest@vger.kernel.org Cc: shuah@kernel.org Link: http://lkml.kernel.org/r/20180211111013.16888-4-linux@dominikbrodowski.net Signed-off-by: Ingo Molnar --- tools/testing/selftests/x86/test_mremap_vdso.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/testing/selftests/x86/test_mremap_vdso.c index bf0d687..64f11c8 100644 --- a/tools/testing/selftests/x86/test_mremap_vdso.c +++ b/tools/testing/selftests/x86/test_mremap_vdso.c @@ -90,8 +90,12 @@ int main(int argc, char **argv, char **envp) vdso_size += PAGE_SIZE; } +#ifdef __i386__ /* Glibc is likely to explode now - exit with raw syscall */ asm volatile ("int $0x80" : : "a" (__NR_exit), "b" (!!ret)); +#else /* __x86_64__ */ + syscall(SYS_exit, ret); +#endif } else { int status;