From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751539AbcGNKjm (ORCPT ); Thu, 14 Jul 2016 06:39:42 -0400 Received: from terminus.zytor.com ([198.137.202.10]:51060 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbcGNKje (ORCPT ); Thu, 14 Jul 2016 06:39:34 -0400 Date: Thu, 14 Jul 2016 03:38:59 -0700 From: tip-bot for Rik van Riel Message-ID: Cc: fweisbec@gmail.com, rkrcmar@redhat.com, efault@gmx.de, torvalds@linux-foundation.org, peterz@infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, riel@redhat.com, pbonzini@redhat.com, mingo@kernel.org, wanpeng.li@hotmail.com, hpa@zytor.com Reply-To: hpa@zytor.com, wanpeng.li@hotmail.com, mingo@kernel.org, pbonzini@redhat.com, riel@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org, rkrcmar@redhat.com, torvalds@linux-foundation.org, efault@gmx.de, fweisbec@gmail.com In-Reply-To: <1468421405-20056-6-git-send-email-fweisbec@gmail.com> References: <1468421405-20056-6-git-send-email-fweisbec@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/nohz] sched/cputime: Drop local_irq_save/restore from irqtime_account_irq() Git-Commit-ID: 553bf6bbfd8a540c70aee28eb50e24caff456a03 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 553bf6bbfd8a540c70aee28eb50e24caff456a03 Gitweb: http://git.kernel.org/tip/553bf6bbfd8a540c70aee28eb50e24caff456a03 Author: Rik van Riel AuthorDate: Wed, 13 Jul 2016 16:50:05 +0200 Committer: Ingo Molnar CommitDate: Thu, 14 Jul 2016 10:42:35 +0200 sched/cputime: Drop local_irq_save/restore from irqtime_account_irq() Paolo pointed out that irqs are already blocked when irqtime_account_irq() is called. That means there is no reason to call local_irq_save/restore() again. Suggested-by: Paolo Bonzini Signed-off-by: Rik van Riel Signed-off-by: Frederic Weisbecker Reviewed-by: Paolo Bonzini Cc: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Radim Krcmar Cc: Thomas Gleixner Cc: Wanpeng Li Link: http://lkml.kernel.org/r/1468421405-20056-6-git-send-email-fweisbec@gmail.com Signed-off-by: Ingo Molnar --- kernel/sched/cputime.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index 16a873c..ea0f6f3 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c @@ -49,15 +49,12 @@ DEFINE_PER_CPU(seqcount_t, irq_time_seq); */ void irqtime_account_irq(struct task_struct *curr) { - unsigned long flags; s64 delta; int cpu; if (!sched_clock_irqtime) return; - local_irq_save(flags); - cpu = smp_processor_id(); delta = sched_clock_cpu(cpu) - __this_cpu_read(irq_start_time); __this_cpu_add(irq_start_time, delta); @@ -75,7 +72,6 @@ void irqtime_account_irq(struct task_struct *curr) __this_cpu_add(cpu_softirq_time, delta); irq_time_write_end(); - local_irq_restore(flags); } EXPORT_SYMBOL_GPL(irqtime_account_irq);