From: tip-bot for Peter Zijlstra <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: linux-kernel@vger.kernel.org, diego.viola@gmail.com, tglx@linutronix.de, mingo@kernel.org, rafael.j.wysocki@intel.com, hpa@zytor.com, peterz@infradead.org Subject: [tip:timers/urgent] clocksource: Initialize cs->wd_list Date: Wed, 2 May 2018 07:13:49 -0700 [thread overview] Message-ID: <tip-5b9e886a4af97574ca3ce1147f35545da0e7afc7@git.kernel.org> (raw) In-Reply-To: <20180430100344.472662715@infradead.org> Commit-ID: 5b9e886a4af97574ca3ce1147f35545da0e7afc7 Gitweb: https://git.kernel.org/tip/5b9e886a4af97574ca3ce1147f35545da0e7afc7 Author: Peter Zijlstra <peterz@infradead.org> AuthorDate: Mon, 30 Apr 2018 12:00:11 +0200 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Wed, 2 May 2018 16:10:40 +0200 clocksource: Initialize cs->wd_list A number of places relies on list_empty(&cs->wd_list), however the list_head does not get initialized. Do so upon registration, such that thereafter it is possible to rely on list_empty() correctly reflecting the list membership status. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Tested-by: Diego Viola <diego.viola@gmail.com> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Cc: stable@vger.kernel.org Cc: len.brown@intel.com Cc: rjw@rjwysocki.net Cc: rui.zhang@intel.com Link: https://lkml.kernel.org/r/20180430100344.472662715@infradead.org --- kernel/time/clocksource.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index c3d2b94723dc..935f39eb8aac 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -332,6 +332,8 @@ static void clocksource_resume_watchdog(void) static void clocksource_enqueue_watchdog(struct clocksource *cs) { + INIT_LIST_HEAD(&cs->wd_list); + if (cs->flags & CLOCK_SOURCE_MUST_VERIFY) { /* cs is a clocksource to be watched. */ list_add(&cs->wd_list, &watchdog_list);
next prev parent reply other threads:[~2018-05-02 14:14 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-30 10:00 [PATCH v2 0/7] Various tsc/clocksource fixes Peter Zijlstra 2018-04-30 10:00 ` [PATCH v2 1/7] x86,tsc: Always unregister clocksource_tsc_early Peter Zijlstra 2018-05-02 14:12 ` [tip:timers/urgent] x86/tsc: " tip-bot for Peter Zijlstra 2018-04-30 10:00 ` [PATCH v2 2/7] clocksource: Allow clocksource_mark_unstable() on unregisered clocksources Peter Zijlstra 2018-05-02 13:35 ` Thomas Gleixner 2018-05-02 13:53 ` Peter Zijlstra 2018-05-02 14:13 ` [tip:timers/urgent] clocksource: Allow clocksource_mark_unstable() on unregistered clocksources tip-bot for Peter Zijlstra 2018-04-30 10:00 ` [PATCH v2 3/7] clocksource: Initialize cs->wd_list Peter Zijlstra 2018-05-02 13:37 ` Thomas Gleixner 2018-05-02 13:55 ` Peter Zijlstra 2018-05-02 14:13 ` tip-bot for Peter Zijlstra [this message] 2018-04-30 10:00 ` [PATCH v2 4/7] x86,tsc: Fix mark_tsc_unstable() Peter Zijlstra 2018-05-02 14:14 ` [tip:timers/urgent] x86/tsc: " tip-bot for Peter Zijlstra 2018-04-30 10:00 ` [PATCH v2 5/7] clocksource: Consistent de-rate when marking unstable Peter Zijlstra 2018-05-02 14:14 ` [tip:timers/urgent] " tip-bot for Peter Zijlstra 2018-04-30 10:00 ` [PATCH v2 6/7] clocksource: Rework stale comment Peter Zijlstra 2018-05-02 14:15 ` [tip:timers/urgent] " tip-bot for Peter Zijlstra 2018-04-30 10:00 ` [PATCH v2 7/7] clocksource: Remove kthread Peter Zijlstra 2018-05-02 14:42 ` [tip:timers/core] " tip-bot for Peter Zijlstra 2018-05-01 9:12 ` [PATCH v2 0/7] Various tsc/clocksource fixes Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tip-5b9e886a4af97574ca3ce1147f35545da0e7afc7@git.kernel.org \ --to=tipbot@zytor.com \ --cc=diego.viola@gmail.com \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=rafael.j.wysocki@intel.com \ --cc=tglx@linutronix.de \ --subject='Re: [tip:timers/urgent] clocksource: Initialize cs->wd_list' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.