From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbdFVQ66 (ORCPT ); Thu, 22 Jun 2017 12:58:58 -0400 Received: from terminus.zytor.com ([65.50.211.136]:40855 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224AbdFVQ65 (ORCPT ); Thu, 22 Jun 2017 12:58:57 -0400 Date: Thu, 22 Jun 2017 09:54:19 -0700 From: tip-bot for Thomas Gleixner Message-ID: Cc: peterz@infradead.org, keith.busch@intel.com, mpe@ellerman.id.au, hch@lst.de, marc.zyngier@arm.com, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, axboe@kernel.dk, linux-kernel@vger.kernel.org Reply-To: hpa@zytor.com, marc.zyngier@arm.com, tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, peterz@infradead.org, keith.busch@intel.com, mpe@ellerman.id.au, hch@lst.de In-Reply-To: <20170619235445.274852976@linutronix.de> References: <20170619235445.274852976@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] genirq/cpuhotplug: Dont claim success on error Git-Commit-ID: 735c09524d3e7c92315e8e2699a1b9acb4fb415c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 735c09524d3e7c92315e8e2699a1b9acb4fb415c Gitweb: http://git.kernel.org/tip/735c09524d3e7c92315e8e2699a1b9acb4fb415c Author: Thomas Gleixner AuthorDate: Tue, 20 Jun 2017 01:37:26 +0200 Committer: Thomas Gleixner CommitDate: Thu, 22 Jun 2017 18:21:16 +0200 genirq/cpuhotplug: Dont claim success on error In case the affinity of an interrupt was broken, a printk is emitted. But if the affinity cannot be set at all due to a missing irq_set_affinity() callback or due to a failing callback, the message is still printed preceeded by a warning/error. That makes no sense whatsoever. Signed-off-by: Thomas Gleixner Cc: Jens Axboe Cc: Marc Zyngier Cc: Michael Ellerman Cc: Keith Busch Cc: Peter Zijlstra Cc: Christoph Hellwig Link: http://lkml.kernel.org/r/20170619235445.274852976@linutronix.de --- kernel/irq/cpuhotplug.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c index 7051398..9c5521b 100644 --- a/kernel/irq/cpuhotplug.c +++ b/kernel/irq/cpuhotplug.c @@ -37,11 +37,14 @@ static bool migrate_one_irq(struct irq_desc *desc) c = irq_data_get_irq_chip(d); if (!c->irq_set_affinity) { pr_debug("IRQ%u: unable to set affinity\n", d->irq); + ret = false; } else { int r = irq_do_set_affinity(d, affinity, false); - if (r) + if (r) { pr_warn_ratelimited("IRQ%u: set affinity failed(%d).\n", d->irq, r); + ret = false; + } } return ret;