From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752850AbdDNJAI (ORCPT ); Fri, 14 Apr 2017 05:00:08 -0400 Received: from terminus.zytor.com ([65.50.211.136]:40103 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbdDNJAD (ORCPT ); Fri, 14 Apr 2017 05:00:03 -0400 Date: Fri, 14 Apr 2017 01:57:51 -0700 From: tip-bot for Tyler Baker Message-ID: Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, fabio.estevam@nxp.com, mingo@kernel.org, hpa@zytor.com, tyler.baker@linaro.org Reply-To: hpa@zytor.com, tyler.baker@linaro.org, mingo@kernel.org, fabio.estevam@nxp.com, tglx@linutronix.de, linux-kernel@vger.kernel.org In-Reply-To: <20170413222731.5917-1-tyler.baker@linaro.org> References: <20170413222731.5917-1-tyler.baker@linaro.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/urgent] irqchip/irq-imx-gpcv2: Fix spinlock initialization Git-Commit-ID: 75eb5e1e7b4edbc8e8f930de59004d21cb46961f X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 75eb5e1e7b4edbc8e8f930de59004d21cb46961f Gitweb: http://git.kernel.org/tip/75eb5e1e7b4edbc8e8f930de59004d21cb46961f Author: Tyler Baker AuthorDate: Thu, 13 Apr 2017 15:27:31 -0700 Committer: Thomas Gleixner CommitDate: Fri, 14 Apr 2017 10:55:05 +0200 irqchip/irq-imx-gpcv2: Fix spinlock initialization The raw_spinlock in the IMX GPCV2 interupt chip is not initialized before usage. That results in a lockdep splat: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. Add the missing raw_spin_lock_init() to the setup code. Fixes: e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup sources") Signed-off-by: Tyler Baker Reviewed-by: Fabio Estevam Cc: jason@lakedaemon.net Cc: marc.zyngier@arm.com Cc: shawnguo@kernel.org Cc: andrew.smirnov@gmail.com Cc: linux-arm-kernel@lists.infradead.org Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/20170413222731.5917-1-tyler.baker@linaro.org Signed-off-by: Thomas Gleixner --- drivers/irqchip/irq-imx-gpcv2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c index 15af9a9..2d203b4 100644 --- a/drivers/irqchip/irq-imx-gpcv2.c +++ b/drivers/irqchip/irq-imx-gpcv2.c @@ -230,6 +230,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node, return -ENOMEM; } + raw_spin_lock_init(&cd->rlock); + cd->gpc_base = of_iomap(node, 0); if (!cd->gpc_base) { pr_err("fsl-gpcv2: unable to map gpc registers\n");