From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756705AbcBCLde (ORCPT ); Wed, 3 Feb 2016 06:33:34 -0500 Received: from terminus.zytor.com ([198.137.202.10]:55640 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756565AbcBCLd3 (ORCPT ); Wed, 3 Feb 2016 06:33:29 -0500 Date: Wed, 3 Feb 2016 03:32:27 -0800 From: tip-bot for Ard Biesheuvel Message-ID: Cc: bp@alien8.de, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, torvalds@linux-foundation.org, matt@codeblueprint.co.uk, brgerst@gmail.com, peterz@infradead.org, hpa@zytor.com, mingo@kernel.org, tglx@linutronix.de, ard.biesheuvel@linaro.org Reply-To: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, torvalds@linux-foundation.org, matt@codeblueprint.co.uk, brgerst@gmail.com, dvlasenk@redhat.com, hpa@zytor.com, ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@kernel.org In-Reply-To: <1454364428-494-6-git-send-email-matt@codeblueprint.co.uk> References: <1454364428-494-6-git-send-email-matt@codeblueprint.co.uk> To: linux-tip-commits@vger.kernel.org Subject: [tip:efi/core] efi/runtime-wrappers: Remove out of date comment regarding in_nmi() Git-Commit-ID: 774846defceb16dcab2f0215cfc467f7c93f1c26 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 774846defceb16dcab2f0215cfc467f7c93f1c26 Gitweb: http://git.kernel.org/tip/774846defceb16dcab2f0215cfc467f7c93f1c26 Author: Ard Biesheuvel AuthorDate: Mon, 1 Feb 2016 22:06:59 +0000 Committer: Ingo Molnar CommitDate: Wed, 3 Feb 2016 11:31:04 +0100 efi/runtime-wrappers: Remove out of date comment regarding in_nmi() This code is long gone, so remove the comment as well. Signed-off-by: Ard Biesheuvel Signed-off-by: Matt Fleming Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/1454364428-494-6-git-send-email-matt@codeblueprint.co.uk Signed-off-by: Ingo Molnar --- drivers/firmware/efi/runtime-wrappers.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c index e9f2867..311f415 100644 --- a/drivers/firmware/efi/runtime-wrappers.c +++ b/drivers/firmware/efi/runtime-wrappers.c @@ -62,32 +62,6 @@ static DEFINE_SPINLOCK(efi_runtime_lock); /* - * Some runtime services calls can be reentrant under NMI, even if the table - * above says they are not. (source: UEFI Specification v2.4A) - * - * Table 32. Functions that may be called after Machine Check, INIT and NMI - * +----------------------------+------------------------------------------+ - * | Function | Called after Machine Check, INIT and NMI | - * +----------------------------+------------------------------------------+ - * | GetTime() | Yes, even if previously busy. | - * | GetVariable() | Yes, even if previously busy | - * | GetNextVariableName() | Yes, even if previously busy | - * | QueryVariableInfo() | Yes, even if previously busy | - * | SetVariable() | Yes, even if previously busy | - * | UpdateCapsule() | Yes, even if previously busy | - * | QueryCapsuleCapabilities() | Yes, even if previously busy | - * | ResetSystem() | Yes, even if previously busy | - * +----------------------------+------------------------------------------+ - * - * In order to prevent deadlocks under NMI, the wrappers for these functions - * may only grab the efi_runtime_lock or rtc_lock spinlocks if !efi_in_nmi(). - * However, not all of the services listed are reachable through NMI code paths, - * so the the special handling as suggested by the UEFI spec is only implemented - * for QueryVariableInfo() and SetVariable(), as these can be reached in NMI - * context through efi_pstore_write(). - */ - -/* * As per commit ef68c8f87ed1 ("x86: Serialize EFI time accesses on rtc_lock"), * the EFI specification requires that callers of the time related runtime * functions serialize with other CMOS accesses in the kernel, as the EFI time