From: tip-bot for Andi Kleen <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: ak@linux.intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org Subject: [tip:x86/timers] x86/timer: Don't inline __const_udelay() Date: Fri, 19 Apr 2019 08:55:03 -0700 [thread overview] Message-ID: <tip-81423c37415fe45057d64196ae0ce8e17a9c7148@git.kernel.org> (raw) In-Reply-To: <20190330004743.29541-4-andi@firstfloor.org> Commit-ID: 81423c37415fe45057d64196ae0ce8e17a9c7148 Gitweb: https://git.kernel.org/tip/81423c37415fe45057d64196ae0ce8e17a9c7148 Author: Andi Kleen <ak@linux.intel.com> AuthorDate: Fri, 29 Mar 2019 17:47:38 -0700 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Fri, 19 Apr 2019 17:49:47 +0200 x86/timer: Don't inline __const_udelay() LTO will happily inline __const_udelay() everywhere it is used. Forcing it noinline saves ~44k text in a LTO build. 13999560 1740864 1499136 17239560 1070e08 vmlinux-with-udelay-inline 13954764 1736768 1499136 17190668 1064f0c vmlinux-wo-udelay-inline Even without LTO this function should never be inlined. Signed-off-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lkml.kernel.org/r/20190330004743.29541-4-andi@firstfloor.org --- arch/x86/lib/delay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c index f5b7f1b3b6d7..b7375dc6898f 100644 --- a/arch/x86/lib/delay.c +++ b/arch/x86/lib/delay.c @@ -162,7 +162,7 @@ void __delay(unsigned long loops) } EXPORT_SYMBOL(__delay); -void __const_udelay(unsigned long xloops) +noinline void __const_udelay(unsigned long xloops) { unsigned long lpj = this_cpu_read(cpu_info.loops_per_jiffy) ? : loops_per_jiffy; int d0;
next prev parent reply other threads:[~2019-04-19 19:05 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-30 0:47 [PATCH v2 1/9] x86/asm: Mark all top level asm statements as .text Andi Kleen 2019-03-30 0:47 ` [PATCH v2 2/9] x86/cpu/amd: Ifdef 32bit only assembler for 32bit Andi Kleen 2019-04-19 15:52 ` [tip:x86/asm] x86/cpu/amd: Exclude 32bit only assembler from 64bit build tip-bot for Andi Kleen 2019-03-30 0:47 ` [PATCH v2 3/9] x86/paravirt: Replace paravirt patches with data Andi Kleen 2019-04-19 21:26 ` Thomas Gleixner 2019-03-30 0:47 ` [PATCH v2 4/9] x86/timer: Don't inline __const_udelay Andi Kleen 2019-04-19 15:55 ` tip-bot for Andi Kleen [this message] 2019-03-30 0:47 ` [PATCH v2 5/9] x86/xen: Mark xen_vcpu_stolen as __visible Andi Kleen 2019-03-30 10:40 ` Juergen Gross 2019-03-30 0:47 ` [PATCH v2 6/9] x86/hyperv: Make hv_vcpu_is_preempted visible Andi Kleen 2019-04-19 15:58 ` [tip:x86/hyperv] x86/hyperv: Make hv_vcpu_is_preempted() visible tip-bot for Andi Kleen 2019-04-19 16:04 ` [tip:x86/platform] " tip-bot for Andi Kleen 2019-03-30 0:47 ` [PATCH v2 7/9] x86/kprobes: Make trampoline_handler global and visible Andi Kleen 2019-04-19 15:58 ` [tip:x86/core] x86/kprobes: Make trampoline_handler() " tip-bot for Andi Kleen 2019-05-08 11:20 ` [tip:x86/urgent] " tip-bot for Andi Kleen 2019-03-30 0:47 ` [PATCH v2 8/9] x86/kvm: Make steal_time visible Andi Kleen 2019-04-19 16:04 ` [tip:x86/platform] " tip-bot for Andi Kleen 2019-03-30 0:47 ` [PATCH v2 9/9] x86/cpu/bugs: Fix __initconst usage in bugs.c Andi Kleen 2019-04-19 15:16 ` [tip:x86/urgent] x86/cpu/bugs: Use __initconst for 'const' init data tip-bot for Andi Kleen 2019-04-19 15:52 ` [tip:x86/asm] x86/asm: Mark all top level asm statements as .text tip-bot for Andi Kleen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tip-81423c37415fe45057d64196ae0ce8e17a9c7148@git.kernel.org \ --to=tipbot@zytor.com \ --cc=ak@linux.intel.com \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=tglx@linutronix.de \ --subject='Re: [tip:x86/timers] x86/timer: Don'\''t inline __const_udelay()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.