From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbcEJUb0 (ORCPT ); Tue, 10 May 2016 16:31:26 -0400 Received: from terminus.zytor.com ([198.137.202.10]:58124 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752851AbcEJUbY (ORCPT ); Tue, 10 May 2016 16:31:24 -0400 Date: Tue, 10 May 2016 13:30:36 -0700 From: tip-bot for He Kuang Message-ID: Cc: dsahern@gmail.com, hpa@zytor.com, alexander.shishkin@linux.intel.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org, namhyung@kernel.org, hekuang@huawei.com, eranian@google.com, acme@redhat.com, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, tglx@linutronix.de, peterz@infradead.org, ak@linux.intel.com, mhiramat@kernel.org, jpoimboe@redhat.com, mingo@kernel.org, penberg@kernel.org, jolsa@kernel.org Reply-To: eranian@google.com, acme@redhat.com, sukadev@linux.vnet.ibm.com, adrian.hunter@intel.com, jpoimboe@redhat.com, mingo@kernel.org, ak@linux.intel.com, mhiramat@kernel.org, tglx@linutronix.de, peterz@infradead.org, penberg@kernel.org, jolsa@kernel.org, dsahern@gmail.com, tumanova@linux.vnet.ibm.com, alexander.shishkin@linux.intel.com, hpa@zytor.com, hekuang@huawei.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, wangnan0@huawei.com, kan.liang@intel.com In-Reply-To: <1462525154-125656-2-git-send-email-hekuang@huawei.com> References: <1462525154-125656-2-git-send-email-hekuang@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support Git-Commit-ID: 841e3558b2de6d8c53dae4f01c7a81cd53e42e5c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 841e3558b2de6d8c53dae4f01c7a81cd53e42e5c Gitweb: http://git.kernel.org/tip/841e3558b2de6d8c53dae4f01c7a81cd53e42e5c Author: He Kuang AuthorDate: Fri, 6 May 2016 08:59:07 +0000 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 9 May 2016 13:29:36 -0300 perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support There is no need to check for DWARF unwinding support when using the 'dwarf' callchain record method, as this will only ask the kernel to collect stack dumps for later DWARF CFI processing, which can be done in another machine, where the support for DWARF unwinding need to be present. Signed-off-by: He Kuang Acked-by: Jiri Olsa Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: David Ahern Cc: Ekaterina Tumanova Cc: Josh Poimboeuf Cc: Kan Liang Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Pekka Enberg Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Sukadev Bhattiprolu Cc: Wang Nan Link: http://lkml.kernel.org/r/1462525154-125656-2-git-send-email-hekuang@huawei.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/util.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index 619ba20..01c9433 100644 --- a/tools/perf/util/util.c +++ b/tools/perf/util/util.c @@ -507,7 +507,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) "needed for --call-graph fp\n"); break; -#ifdef HAVE_DWARF_UNWIND_SUPPORT /* Dwarf style */ } else if (!strncmp(name, "dwarf", sizeof("dwarf"))) { const unsigned long default_stack_dump_size = 8192; @@ -523,7 +522,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) ret = get_stack_size(tok, &size); param->dump_size = size; } -#endif /* HAVE_DWARF_UNWIND_SUPPORT */ } else if (!strncmp(name, "lbr", sizeof("lbr"))) { if (!strtok_r(NULL, ",", &saveptr)) { param->record_mode = CALLCHAIN_LBR;