From: tip-bot for kbuild test robot <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: bp@suse.de, linux-kernel@vger.kernel.org, keescook@chromium.org,
fengguang.wu@intel.com, tglx@linutronix.de, mingo@kernel.org,
hpa@zytor.com, thomas.lendacky@amd.com, jgross@suse.com,
brijesh.singh@amd.com, mpe@ellerman.id.au
Subject: [tip:x86/asm] resource: Fix resource_size.cocci warnings
Date: Tue, 7 Nov 2017 11:49:08 -0800 [thread overview]
Message-ID: <tip-9275b933d409d3a4efa08102ca813557b93fb0b9@git.kernel.org> (raw)
In-Reply-To: <20171107191801.GA91887@lkp-snb01>
Commit-ID: 9275b933d409d3a4efa08102ca813557b93fb0b9
Gitweb: https://git.kernel.org/tip/9275b933d409d3a4efa08102ca813557b93fb0b9
Author: kbuild test robot <fengguang.wu@intel.com>
AuthorDate: Wed, 8 Nov 2017 03:18:01 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 7 Nov 2017 20:44:56 +0100
resource: Fix resource_size.cocci warnings
arch/x86/kernel/crash.c:627:34-37: ERROR: Missing resource_size with res
arch/x86/kernel/crash.c:528:16-19: ERROR: Missing resource_size with res
Use resource_size function on resource object
instead of explicit computation.
Generated by: scripts/coccinelle/api/resource_size.cocci
Fixes: 1d2e733b13b4 ("resource: Provide resource struct in resource walk callback")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Juergen Gross <jgross@suse.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: kbuild-all@01.org
Cc: tipbuild@zytor.com
Cc: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20171107191801.GA91887@lkp-snb01
---
arch/x86/kernel/crash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 815008c..10e74d4 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -525,7 +525,7 @@ static int memmap_entry_callback(struct resource *res, void *arg)
struct e820_entry ei;
ei.addr = res->start;
- ei.size = res->end - res->start + 1;
+ ei.size = resource_size(res);
ei.type = cmd->type;
add_e820_entry(params, &ei);
@@ -624,7 +624,7 @@ static int determine_backup_region(struct resource *res, void *arg)
struct kimage *image = arg;
image->arch.backup_src_start = res->start;
- image->arch.backup_src_sz = res->end - res->start + 1;
+ image->arch.backup_src_sz = resource_size(res);
/* Expecting only one range for backup region */
return 1;
prev parent reply other threads:[~2017-11-07 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 19:18 [tip:x86/asm 9/17] arch/x86/kernel/crash.c:627:34-37: ERROR: Missing resource_size with res kbuild test robot
2017-11-07 19:18 ` [PATCH] resource: fix resource_size.cocci warnings kbuild test robot
2017-11-07 19:49 ` tip-bot for kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9275b933d409d3a4efa08102ca813557b93fb0b9@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.