All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Thomas Gleixner <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: airlied@linux.ie, tom.zanussi@linux.intel.com, agk@redhat.com,
	snitzer@redhat.com, cl@linux.com, hpa@zytor.com,
	jpoimboe@redhat.com, mingo@kernel.org, akinobu.mita@gmail.com,
	rostedt@goodmis.org, luto@kernel.org,
	joonas.lahtinen@linux.intel.com, daniel@ffwll.ch,
	linux-kernel@vger.kernel.org, dsterba@suse.com,
	glider@google.com, tglx@linutronix.de, rppt@linux.vnet.ibm.com,
	rodrigo.vivi@intel.com, dvyukov@google.com, penberg@kernel.org,
	maarten.lankhorst@linux.intel.com, clm@fb.com,
	jthumshirn@suse.de, rientjes@google.com,
	m.szyprowski@samsung.com, hch@lst.de,
	jani.nikula@linux.intel.com, aryabinin@virtuozzo.com,
	mbenes@suse.cz, adobriyan@gmail.com, catalin.marinas@arm.com,
	josef@toxicpanda.com, robin.murphy@arm.com,
	akpm@linux-foundation.org
Subject: [tip:core/stacktrace] stacktrace: Remove obsolete functions
Date: Mon, 29 Apr 2019 11:48:27 -0700	[thread overview]
Message-ID: <tip-988ec8841ca1e22b2978fce0134d8267e838770e@git.kernel.org> (raw)
In-Reply-To: <20190425094803.524796783@linutronix.de>

Commit-ID:  988ec8841ca1e22b2978fce0134d8267e838770e
Gitweb:     https://git.kernel.org/tip/988ec8841ca1e22b2978fce0134d8267e838770e
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Thu, 25 Apr 2019 11:45:19 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 29 Apr 2019 12:37:57 +0200

stacktrace: Remove obsolete functions

No more users of the struct stack_trace based interfaces. Remove them.

Remove the macro stubs for !CONFIG_STACKTRACE as well as they are pointless
because the storage on the call sites is conditional on CONFIG_STACKTRACE
already. No point to be 'smart'.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: linux-mm@kvack.org
Cc: David Rientjes <rientjes@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: kasan-dev@googlegroups.com
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Cc: David Sterba <dsterba@suse.com>
Cc: Chris Mason <clm@fb.com>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org
Cc: dm-devel@redhat.com
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: Miroslav Benes <mbenes@suse.cz>
Cc: linux-arch@vger.kernel.org
Link: https://lkml.kernel.org/r/20190425094803.524796783@linutronix.de

---
 include/linux/stacktrace.h | 17 -----------------
 kernel/stacktrace.c        | 14 --------------
 2 files changed, 31 deletions(-)

diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h
index a24340b3e9e1..40decfbb9a24 100644
--- a/include/linux/stacktrace.h
+++ b/include/linux/stacktrace.h
@@ -36,24 +36,7 @@ extern void save_stack_trace_tsk(struct task_struct *tsk,
 				struct stack_trace *trace);
 extern int save_stack_trace_tsk_reliable(struct task_struct *tsk,
 					 struct stack_trace *trace);
-
-extern void print_stack_trace(struct stack_trace *trace, int spaces);
-extern int snprint_stack_trace(char *buf, size_t size,
-			struct stack_trace *trace, int spaces);
-
-#ifdef CONFIG_USER_STACKTRACE_SUPPORT
 extern void save_stack_trace_user(struct stack_trace *trace);
-#else
-# define save_stack_trace_user(trace)              do { } while (0)
-#endif
-
-#else /* !CONFIG_STACKTRACE */
-# define save_stack_trace(trace)			do { } while (0)
-# define save_stack_trace_tsk(tsk, trace)		do { } while (0)
-# define save_stack_trace_user(trace)			do { } while (0)
-# define print_stack_trace(trace, spaces)		do { } while (0)
-# define snprint_stack_trace(buf, size, trace, spaces)	do { } while (0)
-# define save_stack_trace_tsk_reliable(tsk, trace)	({ -ENOSYS; })
 #endif /* CONFIG_STACKTRACE */
 
 #if defined(CONFIG_STACKTRACE) && defined(CONFIG_HAVE_RELIABLE_STACKTRACE)
diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
index b38333b3bc18..dd55312f3fe9 100644
--- a/kernel/stacktrace.c
+++ b/kernel/stacktrace.c
@@ -30,12 +30,6 @@ void stack_trace_print(unsigned long *entries, unsigned int nr_entries,
 }
 EXPORT_SYMBOL_GPL(stack_trace_print);
 
-void print_stack_trace(struct stack_trace *trace, int spaces)
-{
-	stack_trace_print(trace->entries, trace->nr_entries, spaces);
-}
-EXPORT_SYMBOL_GPL(print_stack_trace);
-
 /**
  * stack_trace_snprint - Print the entries in the stack trace into a buffer
  * @buf:	Pointer to the print buffer
@@ -72,14 +66,6 @@ int stack_trace_snprint(char *buf, size_t size, unsigned long *entries,
 }
 EXPORT_SYMBOL_GPL(stack_trace_snprint);
 
-int snprint_stack_trace(char *buf, size_t size,
-			struct stack_trace *trace, int spaces)
-{
-	return stack_trace_snprint(buf, size, trace->entries,
-				   trace->nr_entries, spaces);
-}
-EXPORT_SYMBOL_GPL(snprint_stack_trace);
-
 /*
  * Architectures that do not implement save_stack_trace_*()
  * get these weak aliases and once-per-bootup warnings

  reply	other threads:[~2019-04-29 18:49 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25  9:44 [patch V3 00/29] stacktrace: Consolidate stack trace usage Thomas Gleixner
2019-04-25  9:44 ` Thomas Gleixner
2019-04-25  9:44 ` Thomas Gleixner
2019-04-25  9:44 ` [patch V3 01/29] tracing: Cleanup stack trace code Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-29 18:31   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:44 ` [patch V3 02/29] stacktrace: Provide helpers for common stack trace operations Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-29 18:31   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:44 ` [patch V3 03/29] lib/stackdepot: Provide functions which operate on plain storage arrays Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-29 18:32   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:44 ` [patch V3 04/29] backtrace-test: Simplify stack trace handling Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-29 18:33   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:44 ` [patch V3 05/29] proc: Simplify task stack retrieval Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-29 18:34   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:44 ` [patch V3 06/29] latency_top: Simplify stack trace handling Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-25  9:44   ` Thomas Gleixner
2019-04-29 18:34   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 07/29] mm/slub: Simplify stack trace retrieval Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:35   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 08/29] mm/kmemleak: Simplify stacktrace handling Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:36   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 09/29] mm/kasan: " Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:36   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 10/29] mm/page_owner: Simplify stack trace handling Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:37   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 11/29] fault-inject: Simplify stacktrace retrieval Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:38   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 12/29] dma/debug: Simplify stracktrace retrieval Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:39   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 13/29] btrfs: ref-verify: Simplify stack trace retrieval Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:39   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 14/29] dm bufio: " Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:40   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 15/29] dm persistent data: Simplify stack trace handling Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:41   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 16/29] drm: Simplify stacktrace handling Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:41   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 17/29] lockdep: Remove unused trace argument from print_circular_bug() Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:42   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 18/29] lockdep: Remove save argument from check_prev_add() Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25 13:35   ` Peter Zijlstra
2019-04-25 13:35     ` Peter Zijlstra
2019-04-25 13:35     ` Peter Zijlstra
2019-04-29 18:43   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 19/29] lockdep: Simplify stack trace handling Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:43   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 20/29] tracing: Simplify stacktrace retrieval in histograms Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:44   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 21/29] tracing: Use percpu stack trace buffer more intelligently Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25 13:29   ` Josh Poimboeuf
2019-04-25 13:29     ` Josh Poimboeuf
2019-04-25 13:29     ` Josh Poimboeuf
2019-04-29 18:45   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 22/29] tracing: Make ftrace_trace_userstack() static and conditional Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:45   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 23/29] tracing: Simplify stack trace retrieval Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:46   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 24/29] tracing: Remove the last struct stack_trace usage Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25 13:30   ` Josh Poimboeuf
2019-04-25 13:30     ` Josh Poimboeuf
2019-04-25 13:30     ` Josh Poimboeuf
2019-04-29 18:47   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 25/29] livepatch: Simplify stack trace retrieval Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:47   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 26/29] stacktrace: Remove obsolete functions Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:48   ` tip-bot for Thomas Gleixner [this message]
2019-04-25  9:45 ` [patch V3 27/29] lib/stackdepot: " Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:49   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 28/29] stacktrace: Provide common infrastructure Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:49   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25  9:45 ` [patch V3 29/29] x86/stacktrace: Use " Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-25  9:45   ` Thomas Gleixner
2019-04-29 18:50   ` [tip:core/stacktrace] " tip-bot for Thomas Gleixner
2019-04-25 10:09 ` [patch V3 00/29] stacktrace: Consolidate stack trace usage Ingo Molnar
2019-04-25 10:09   ` Ingo Molnar
2019-04-25 10:09   ` Ingo Molnar
2019-04-25 12:00 ` ✗ Fi.CI.BAT: failure for stacktrace: Consolidate stack trace usage (rev2) Patchwork
2019-04-25 13:31 ` [patch V3 00/29] stacktrace: Consolidate stack trace usage Josh Poimboeuf
2019-04-25 13:31   ` Josh Poimboeuf
2019-04-25 13:31   ` Josh Poimboeuf
2019-04-25 14:45 ` ✗ Fi.CI.BAT: failure for stacktrace: Consolidate stack trace usage (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-988ec8841ca1e22b2978fce0134d8267e838770e@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=adobriyan@gmail.com \
    --cc=agk@redhat.com \
    --cc=airlied@linux.ie \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=catalin.marinas@arm.com \
    --cc=cl@linux.com \
    --cc=clm@fb.com \
    --cc=daniel@ffwll.ch \
    --cc=dsterba@suse.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=josef@toxicpanda.com \
    --cc=jpoimboe@redhat.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mbenes@suse.cz \
    --cc=mingo@kernel.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=robin.murphy@arm.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=snitzer@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tom.zanussi@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.