From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A60C43219 for ; Tue, 30 Apr 2019 06:01:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E9FD2147A for ; Tue, 30 Apr 2019 06:01:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="ms8jpUI9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726165AbfD3GBX (ORCPT ); Tue, 30 Apr 2019 02:01:23 -0400 Received: from terminus.zytor.com ([198.137.202.136]:42313 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbfD3GBW (ORCPT ); Tue, 30 Apr 2019 02:01:22 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x3U619291246069 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 29 Apr 2019 23:01:09 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x3U619291246069 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019041745; t=1556604070; bh=UiBnw9h+elpv8WbkvKPR3PV6tRWXBHupSv15r3HFhos=; h=Date:From:Cc:Reply-To:In-Reply-To:References:To:Subject:From; b=ms8jpUI9+4rjkqhZPzQg7Bl1hvgZvMHoVgOY5F1ZR47/6HI/oZEWRN/eqzifTlmFr TfOJe/l94HJQB1a1wxdCH3DOYdVIrT6JtL8gkq2BwKNn7VJxJ5l7R4YEC2zon2fhp/ 7Wu74Q1s91V3Hl0kHxDZumnFZi+wfxvOTnOYApE3VdieHcPsrhMMqtLyEBEfVpKQsd OERubylvjkdqYW4G1o1NkLZkJ1AaGwHFkczcBCub7nje14JQLGKjRkzKnU48zbH1q2 WiLKuLvCH+qV+qf2sGCyPuFUCK2Y+6UkyA1gyewTWF312zPltY2Qt62ilgl4vwOX5n egLXkDwEwSrUA== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x3U6195r1246066; Mon, 29 Apr 2019 23:01:09 -0700 Date: Mon, 29 Apr 2019 23:01:09 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: "tip-bot for Tobin C. Harding" Message-ID: Cc: linux-kernel@vger.kernel.org, tobin@kernel.org, gregkh@linuxfoundation.org, tglx@linutronix.de, hpa@zytor.com, peterz@infradead.org, vincent.guittot@linaro.org, viresh.kumar@linaro.org, mingo@kernel.org, torvalds@linux-foundation.org, rafael.j.wysocki@intel.com Reply-To: peterz@infradead.org, vincent.guittot@linaro.org, viresh.kumar@linaro.org, rafael.j.wysocki@intel.com, torvalds@linux-foundation.org, mingo@kernel.org, linux-kernel@vger.kernel.org, tobin@kernel.org, hpa@zytor.com, tglx@linutronix.de, gregkh@linuxfoundation.org In-Reply-To: <20190430001144.24890-1-tobin@kernel.org> References: <20190430001144.24890-1-tobin@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/urgent] sched/cpufreq: Fix kobject memleak Git-Commit-ID: 9a4f26cc98d81b67ecc23b890c28e2df324e29f3 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 9a4f26cc98d81b67ecc23b890c28e2df324e29f3 Gitweb: https://git.kernel.org/tip/9a4f26cc98d81b67ecc23b890c28e2df324e29f3 Author: Tobin C. Harding AuthorDate: Tue, 30 Apr 2019 10:11:44 +1000 Committer: Ingo Molnar CommitDate: Tue, 30 Apr 2019 07:57:23 +0200 sched/cpufreq: Fix kobject memleak Currently the error return path from kobject_init_and_add() is not followed by a call to kobject_put() - which means we are leaking the kobject. Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Signed-off-by: Tobin C. Harding Cc: Greg Kroah-Hartman Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Thomas Gleixner Cc: Tobin C. Harding Cc: Vincent Guittot Cc: Viresh Kumar Link: http://lkml.kernel.org/r/20190430001144.24890-1-tobin@kernel.org Signed-off-by: Ingo Molnar --- kernel/sched/cpufreq_schedutil.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 5c41ea367422..3638d2377e3c 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -771,6 +771,7 @@ out: return 0; fail: + kobject_put(&tunables->attr_set.kobj); policy->governor_data = NULL; sugov_tunables_free(tunables);