From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934448AbcBQMNY (ORCPT ); Wed, 17 Feb 2016 07:13:24 -0500 Received: from terminus.zytor.com ([198.137.202.10]:56046 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934285AbcBQMNU (ORCPT ); Wed, 17 Feb 2016 07:13:20 -0500 Date: Wed, 17 Feb 2016 04:12:38 -0800 From: tip-bot for Andrzej Hajda Message-ID: Cc: b.zolnierkie@samsung.com, peterz@infradead.org, torvalds@linux-foundation.org, hpa@zytor.com, a.hajda@samsung.com, bp@suse.de, tglx@linutronix.de, m.szyprowski@samsung.com, mingo@kernel.org, linux-kernel@vger.kernel.org Reply-To: tglx@linutronix.de, mingo@kernel.org, m.szyprowski@samsung.com, linux-kernel@vger.kernel.org, peterz@infradead.org, b.zolnierkie@samsung.com, a.hajda@samsung.com, bp@suse.de, torvalds@linux-foundation.org, hpa@zytor.com In-Reply-To: <1455612202-14414-3-git-send-email-bp@alien8.de> References: <1455612202-14414-3-git-send-email-bp@alien8.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/microcode] x86/microcode: Use kmemdup() rather than duplicating its implementation Git-Commit-ID: 9cc6f743c7724eb9abaf27904194c169db85dd31 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 9cc6f743c7724eb9abaf27904194c169db85dd31 Gitweb: http://git.kernel.org/tip/9cc6f743c7724eb9abaf27904194c169db85dd31 Author: Andrzej Hajda AuthorDate: Tue, 16 Feb 2016 09:43:20 +0100 Committer: Ingo Molnar CommitDate: Wed, 17 Feb 2016 08:46:08 +0100 x86/microcode: Use kmemdup() rather than duplicating its implementation The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci. Signed-off-by: Andrzej Hajda Signed-off-by: Borislav Petkov Cc: Bartlomiej Zolnierkiewicz Cc: Linus Torvalds Cc: Marek Szyprowski Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1455612202-14414-3-git-send-email-bp@alien8.de Signed-off-by: Ingo Molnar --- arch/x86/kernel/cpu/microcode/amd.c | 4 +--- arch/x86/kernel/cpu/microcode/intel.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c index f66cbfe..e397fc1 100644 --- a/arch/x86/kernel/cpu/microcode/amd.c +++ b/arch/x86/kernel/cpu/microcode/amd.c @@ -788,15 +788,13 @@ static int verify_and_add_patch(u8 family, u8 *fw, unsigned int leftover) return -EINVAL; } - patch->data = kzalloc(patch_size, GFP_KERNEL); + patch->data = kmemdup(fw + SECTION_HDR_SIZE, patch_size, GFP_KERNEL); if (!patch->data) { pr_err("Patch data allocation failure.\n"); kfree(patch); return -EINVAL; } - /* All looks ok, copy patch... */ - memcpy(patch->data, fw + SECTION_HDR_SIZE, patch_size); INIT_LIST_HEAD(&patch->plist); patch->patch_id = mc_hdr->patch_id; patch->equiv_cpu = proc_id; diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c index cb397947..cbb3cf0 100644 --- a/arch/x86/kernel/cpu/microcode/intel.c +++ b/arch/x86/kernel/cpu/microcode/intel.c @@ -210,13 +210,11 @@ save_microcode(struct mc_saved_data *mcs, mc_hdr = &mc->hdr; size = get_totalsize(mc_hdr); - saved_ptr[i] = kmalloc(size, GFP_KERNEL); + saved_ptr[i] = kmemdup(mc, size, GFP_KERNEL); if (!saved_ptr[i]) { ret = -ENOMEM; goto err; } - - memcpy(saved_ptr[i], mc, size); } /*