From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935627AbcJFWnb (ORCPT ); Thu, 6 Oct 2016 18:43:31 -0400 Received: from terminus.zytor.com ([198.137.202.10]:46464 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934680AbcJFWnX (ORCPT ); Thu, 6 Oct 2016 18:43:23 -0400 Date: Thu, 6 Oct 2016 15:41:22 -0700 From: tip-bot for Namhyung Kim Message-ID: Cc: acme@redhat.com, tglx@linutronix.de, namhyung@kernel.org, rostedt@goodmis.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, hpa@zytor.com, mingo@kernel.org Reply-To: mingo@kernel.org, hpa@zytor.com, rostedt@goodmis.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, jolsa@kernel.org, tglx@linutronix.de, acme@redhat.com In-Reply-To: <20161001101700.29146-1-namhyung@kernel.org> References: <20161001101700.29146-1-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] tools lib traceevent: Fix kbuffer_read_at_offset() Git-Commit-ID: a130347973c408c0e0017a52c74cbc3226c1f0ef X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a130347973c408c0e0017a52c74cbc3226c1f0ef Gitweb: http://git.kernel.org/tip/a130347973c408c0e0017a52c74cbc3226c1f0ef Author: Namhyung Kim AuthorDate: Sat, 1 Oct 2016 19:17:00 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 5 Oct 2016 11:36:22 -0300 tools lib traceevent: Fix kbuffer_read_at_offset() When it's called with an offset less than or equal to the first event, it'll return a garbage value since the data is not initialized. Signed-off-by: Namhyung Kim Acked-by: Steven Rostedt Cc: Jiri Olsa Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20161001101700.29146-1-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/traceevent/kbuffer-parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c index 3bcada3..65984f1 100644 --- a/tools/lib/traceevent/kbuffer-parse.c +++ b/tools/lib/traceevent/kbuffer-parse.c @@ -622,6 +622,7 @@ void *kbuffer_read_at_offset(struct kbuffer *kbuf, int offset, /* Reset the buffer */ kbuffer_load_subbuffer(kbuf, kbuf->subbuffer); + data = kbuffer_read_event(kbuf, ts); while (kbuf->curr < offset) { data = kbuffer_next_event(kbuf, ts);