* [PATCH] x86-64/entry: add instruction suffix
@ 2018-02-26 11:11 Jan Beulich
2018-02-28 14:22 ` [tip:x86/urgent] x86/entry/64: Add " tip-bot for Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2018-02-26 11:11 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: linux-kernel
Omitting suffixes from instructions in AT&T mode is bad practice when
operand size cannot be determined by the assembler from register
operands, and is likely going to be warned about by upstream gas in the
future (mine does already). Add the single missing suffix here.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
arch/x86/entry/entry_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 4.16-rc3/arch/x86/entry/entry_64.S
+++ 4.16-rc3-x86-insn-suffixes/arch/x86/entry/entry_64.S
@@ -55,7 +55,7 @@ END(native_usergs_sysret64)
.macro TRACE_IRQS_FLAGS flags:req
#ifdef CONFIG_TRACE_IRQFLAGS
- bt $9, \flags /* interrupts off? */
+ btl $9, \flags /* interrupts off? */
jnc 1f
TRACE_IRQS_ON
1:
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86/entry/64: Add instruction suffix
2018-02-26 11:11 [PATCH] x86-64/entry: add instruction suffix Jan Beulich
@ 2018-02-28 14:22 ` tip-bot for Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jan Beulich @ 2018-02-28 14:22 UTC (permalink / raw)
To: linux-tip-commits; +Cc: hpa, jbeulich, mingo, linux-kernel, JBeulich, tglx
Commit-ID: a368d7fd2a3c6babb852fe974018dd97916bcd3b
Gitweb: https://git.kernel.org/tip/a368d7fd2a3c6babb852fe974018dd97916bcd3b
Author: Jan Beulich <JBeulich@suse.com>
AuthorDate: Mon, 26 Feb 2018 04:11:21 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 28 Feb 2018 15:18:40 +0100
x86/entry/64: Add instruction suffix
Omitting suffixes from instructions in AT&T mode is bad practice when
operand size cannot be determined by the assembler from register
operands, and is likely going to be warned about by upstream gas in the
future (mine does already). Add the single missing suffix here.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/5A93F96902000078001ABAC8@prv-mh.provo.novell.com
---
arch/x86/entry/entry_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index d5c7f18f79ac..805f52703ee3 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -55,7 +55,7 @@ END(native_usergs_sysret64)
.macro TRACE_IRQS_FLAGS flags:req
#ifdef CONFIG_TRACE_IRQFLAGS
- bt $9, \flags /* interrupts off? */
+ btl $9, \flags /* interrupts off? */
jnc 1f
TRACE_IRQS_ON
1:
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-28 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 11:11 [PATCH] x86-64/entry: add instruction suffix Jan Beulich
2018-02-28 14:22 ` [tip:x86/urgent] x86/entry/64: Add " tip-bot for Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.