From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbdDOO2r (ORCPT ); Sat, 15 Apr 2017 10:28:47 -0400 Received: from terminus.zytor.com ([65.50.211.136]:55217 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754147AbdDOO2q (ORCPT ); Sat, 15 Apr 2017 10:28:46 -0400 Date: Sat, 15 Apr 2017 07:19:06 -0700 From: tip-bot for Thomas Gleixner Message-ID: Cc: fenghua.yu@intel.com, herbert@gondor.apana.org.au, lenb@kernel.org, benh@kernel.crashing.org, hpa@zytor.com, mingo@kernel.org, viresh.kumar@linaro.org, tony.luck@intel.com, bigeasy@linutronix.de, peterz@infradead.org, tj@kernel.org, mpe@ellerman.id.au, jiangshanlai@gmail.com, davem@davemloft.net, linux-kernel@vger.kernel.org, tglx@linutronix.de, rjw@rjwysocki.net Reply-To: hpa@zytor.com, benh@kernel.crashing.org, lenb@kernel.org, fenghua.yu@intel.com, herbert@gondor.apana.org.au, tony.luck@intel.com, viresh.kumar@linaro.org, mingo@kernel.org, davem@davemloft.net, jiangshanlai@gmail.com, mpe@ellerman.id.au, tj@kernel.org, peterz@infradead.org, bigeasy@linutronix.de, rjw@rjwysocki.net, tglx@linutronix.de, linux-kernel@vger.kernel.org In-Reply-To: <20170412201042.695499645@linutronix.de> References: <20170412201042.695499645@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] ACPI/processor: Fix error handling in __acpi_processor_start() Git-Commit-ID: a5cbdf693a60d5b86d4d21dfedd90f17754eb273 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: a5cbdf693a60d5b86d4d21dfedd90f17754eb273 Gitweb: http://git.kernel.org/tip/a5cbdf693a60d5b86d4d21dfedd90f17754eb273 Author: Thomas Gleixner AuthorDate: Wed, 12 Apr 2017 22:07:33 +0200 Committer: Thomas Gleixner CommitDate: Sat, 15 Apr 2017 12:20:54 +0200 ACPI/processor: Fix error handling in __acpi_processor_start() When acpi_install_notify_handler() fails the cooling device stays registered and the sysfs files created via acpi_pss_perf_init() are leaked and the function returns success. Undo acpi_pss_perf_init() and return a proper error code. Signed-off-by: Thomas Gleixner Cc: Fenghua Yu Cc: Tony Luck Cc: Herbert Xu Cc: "Rafael J. Wysocki" Cc: Peter Zijlstra Cc: Benjamin Herrenschmidt Cc: Sebastian Siewior Cc: Lai Jiangshan Cc: linux-acpi@vger.kernel.org Cc: Viresh Kumar Cc: Michael Ellerman Cc: Tejun Heo Cc: "David S. Miller" Cc: Len Brown Link: http://lkml.kernel.org/r/20170412201042.695499645@linutronix.de Signed-off-by: Thomas Gleixner --- drivers/acpi/processor_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c index 9d5f0c7..eab8cda 100644 --- a/drivers/acpi/processor_driver.c +++ b/drivers/acpi/processor_driver.c @@ -251,6 +251,9 @@ static int __acpi_processor_start(struct acpi_device *device) if (ACPI_SUCCESS(status)) return 0; + result = -ENODEV; + acpi_pss_perf_exit(pr, device); + err_power_exit: acpi_processor_power_exit(pr); return result;