From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753803AbbGaOCM (ORCPT ); Fri, 31 Jul 2015 10:02:12 -0400 Received: from terminus.zytor.com ([198.137.202.10]:57497 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753736AbbGaOCD (ORCPT ); Fri, 31 Jul 2015 10:02:03 -0400 Date: Fri, 31 Jul 2015 06:56:21 -0700 From: tip-bot for Andy Lutomirski Message-ID: Cc: dvrabel@cantab.net, luto@amacapital.net, bp@alien8.de, mingo@kernel.org, rostedt@goodmis.org, dvlasenk@redhat.com, andrew.cooper3@citrix.com, stable@vger.kernel.org, tglx@linutronix.de, sasha.levin@oracle.com, brgerst@gmail.com, boris.ostrovsky@oracle.com, hpa@zytor.com, jbeulich@suse.com, peterz@infradead.org, xen-devel@lists.xen.org, luto@kernel.org, linux-kernel@vger.kernel.org, konrad.wilk@oracle.com, torvalds@linux-foundation.org, security@kernel.org Reply-To: hpa@zytor.com, boris.ostrovsky@oracle.com, brgerst@gmail.com, sasha.levin@oracle.com, linux-kernel@vger.kernel.org, peterz@infradead.org, jbeulich@suse.com, xen-devel@lists.xen.org, luto@kernel.org, security@kernel.org, torvalds@linux-foundation.org, konrad.wilk@oracle.com, dvrabel@cantab.net, bp@alien8.de, rostedt@goodmis.org, dvlasenk@redhat.com, mingo@kernel.org, luto@amacapital.net, andrew.cooper3@citrix.com, stable@vger.kernel.org, tglx@linutronix.de In-Reply-To: <0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.luto@kernel.org> References: <0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.luto@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/asm] x86/xen: Probe target addresses in set_aliased_prot () before the hypercall Git-Commit-ID: aa1acff356bbedfd03b544051f5b371746735d89 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: aa1acff356bbedfd03b544051f5b371746735d89 Gitweb: http://git.kernel.org/tip/aa1acff356bbedfd03b544051f5b371746735d89 Author: Andy Lutomirski AuthorDate: Thu, 30 Jul 2015 14:31:31 -0700 Committer: Ingo Molnar CommitDate: Fri, 31 Jul 2015 10:23:22 +0200 x86/xen: Probe target addresses in set_aliased_prot() before the hypercall The update_va_mapping hypercall can fail if the VA isn't present in the guest's page tables. Under certain loads, this can result in an OOPS when the target address is in unpopulated vmap space. While we're at it, add comments to help explain what's going on. This isn't a great long-term fix. This code should probably be changed to use something like set_memory_ro. Signed-off-by: Andy Lutomirski Cc: Andrew Cooper Cc: Andy Lutomirski Cc: Boris Ostrovsky Cc: Borislav Petkov Cc: Brian Gerst Cc: David Vrabel Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Sasha Levin Cc: Steven Rostedt Cc: Thomas Gleixner Cc: security@kernel.org Cc: Cc: xen-devel Link: http://lkml.kernel.org/r/0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.luto@kernel.org Signed-off-by: Ingo Molnar --- arch/x86/xen/enlighten.c | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 0b95c9b..11d6fb4 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -483,6 +483,7 @@ static void set_aliased_prot(void *v, pgprot_t prot) pte_t pte; unsigned long pfn; struct page *page; + unsigned char dummy; ptep = lookup_address((unsigned long)v, &level); BUG_ON(ptep == NULL); @@ -492,6 +493,32 @@ static void set_aliased_prot(void *v, pgprot_t prot) pte = pfn_pte(pfn, prot); + /* + * Careful: update_va_mapping() will fail if the virtual address + * we're poking isn't populated in the page tables. We don't + * need to worry about the direct map (that's always in the page + * tables), but we need to be careful about vmap space. In + * particular, the top level page table can lazily propagate + * entries between processes, so if we've switched mms since we + * vmapped the target in the first place, we might not have the + * top-level page table entry populated. + * + * We disable preemption because we want the same mm active when + * we probe the target and when we issue the hypercall. We'll + * have the same nominal mm, but if we're a kernel thread, lazy + * mm dropping could change our pgd. + * + * Out of an abundance of caution, this uses __get_user() to fault + * in the target address just in case there's some obscure case + * in which the target address isn't readable. + */ + + preempt_disable(); + + pagefault_disable(); /* Avoid warnings due to being atomic. */ + __get_user(dummy, (unsigned char __user __force *)v); + pagefault_enable(); + if (HYPERVISOR_update_va_mapping((unsigned long)v, pte, 0)) BUG(); @@ -503,6 +530,8 @@ static void set_aliased_prot(void *v, pgprot_t prot) BUG(); } else kmap_flush_unused(); + + preempt_enable(); } static void xen_alloc_ldt(struct desc_struct *ldt, unsigned entries) @@ -510,6 +539,17 @@ static void xen_alloc_ldt(struct desc_struct *ldt, unsigned entries) const unsigned entries_per_page = PAGE_SIZE / LDT_ENTRY_SIZE; int i; + /* + * We need to mark the all aliases of the LDT pages RO. We + * don't need to call vm_flush_aliases(), though, since that's + * only responsible for flushing aliases out the TLBs, not the + * page tables, and Xen will flush the TLB for us if needed. + * + * To avoid confusing future readers: none of this is necessary + * to load the LDT. The hypervisor only checks this when the + * LDT is faulted in due to subsequent descriptor access. + */ + for(i = 0; i < entries; i += entries_per_page) set_aliased_prot(ldt + i, PAGE_KERNEL_RO); }