From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933148AbZFQLws (ORCPT ); Wed, 17 Jun 2009 07:52:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932738AbZFQLwk (ORCPT ); Wed, 17 Jun 2009 07:52:40 -0400 Received: from hera.kernel.org ([140.211.167.34]:50874 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932592AbZFQLwj (ORCPT ); Wed, 17 Jun 2009 07:52:39 -0400 Date: Wed, 17 Jun 2009 11:51:33 GMT From: tip-bot for Peter Zijlstra To: linux-tip-commits@vger.kernel.org Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com, akpm@linux-foundation.org, a.p.zijlstra@chello.nl, stable@kernel.org, tglx@linutronix.de, mingo@elte.hu Reply-To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, akpm@linux-foundation.org, stable@kernel.org, tglx@linutronix.de, mingo@elte.hu In-Reply-To: References: Subject: [tip:core/urgent] lockdep: Select frame pointers on x86 Message-ID: Git-Commit-ID: b54eff768d8b6d0b50d90b0a27eb2c3d20b9c91c X-Mailer: tip-git-log-daemon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Wed, 17 Jun 2009 11:51:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b54eff768d8b6d0b50d90b0a27eb2c3d20b9c91c Gitweb: http://git.kernel.org/tip/b54eff768d8b6d0b50d90b0a27eb2c3d20b9c91c Author: Peter Zijlstra AuthorDate: Fri, 12 Jun 2009 10:04:01 +0200 Committer: Ingo Molnar CommitDate: Wed, 17 Jun 2009 13:48:37 +0200 lockdep: Select frame pointers on x86 x86 stack traces are a piece of crap without frame pointers, and its not like the 'performance gain' of not having stack pointers matters when you selected lockdep. Reported-by: Andrew Morton LKML-Reference: Cc: Signed-off-by: Peter Zijlstra Signed-off-by: Ingo Molnar --- lib/Kconfig.debug | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 6cdcf38..3be4b7c 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -440,7 +440,7 @@ config LOCKDEP bool depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT select STACKTRACE - select FRAME_POINTER if !X86 && !MIPS && !PPC && !ARM_UNWIND && !S390 + select FRAME_POINTER if !MIPS && !PPC && !ARM_UNWIND && !S390 select KALLSYMS select KALLSYMS_ALL