From: tip-bot for Peter Zijlstra <tipbot@zytor.com> To: linux-tip-commits@vger.kernel.org Cc: jolsa@redhat.com, rostedt@goodmis.org, fweisbec@gmail.com, hpa@zytor.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, wangnan0@huawei.com, peterz@infradead.org, dsahern@gmail.com, acme@redhat.com, adrian.hunter@intel.com, jolsa@kernel.org, mingo@kernel.org, acme@kernel.org Subject: [tip:perf/urgent] perf: Fix inherited events vs. tracepoint filters Date: Mon, 9 Nov 2015 22:40:07 -0800 [thread overview] Message-ID: <tip-b71b437eedaed985062492565d9d421d975ae845@git.kernel.org> (raw) In-Reply-To: <20151102095051.GN17308@twins.programming.kicks-ass.net> Commit-ID: b71b437eedaed985062492565d9d421d975ae845 Gitweb: http://git.kernel.org/tip/b71b437eedaed985062492565d9d421d975ae845 Author: Peter Zijlstra <peterz@infradead.org> AuthorDate: Mon, 2 Nov 2015 10:50:51 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Mon, 9 Nov 2015 16:13:11 +0100 perf: Fix inherited events vs. tracepoint filters Arnaldo reported that tracepoint filters seem to misbehave (ie. not apply) on inherited events. The fix is obvious; filters are only set on the actual (parent) event, use the normal pattern of using this parent event for filters. This is safe because each child event has a reference to it. Reported-by: Arnaldo Carvalho de Melo <acme@kernel.org> Tested-by: Arnaldo Carvalho de Melo <acme@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Wang Nan <wangnan0@huawei.com> Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/20151102095051.GN17308@twins.programming.kicks-ass.net Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/events/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/events/core.c b/kernel/events/core.c index f8e5c44..98a4b9d 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6909,6 +6909,10 @@ static int perf_tp_filter_match(struct perf_event *event, { void *record = data->raw->data; + /* only top level events have filters set */ + if (event->parent) + event = event->parent; + if (likely(!event->filter) || filter_match_preds(event->filter, record)) return 1; return 0;
prev parent reply other threads:[~2015-11-10 6:41 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-29 15:27 tracepoint filter problems Arnaldo Carvalho de Melo 2015-11-02 9:50 ` Peter Zijlstra 2015-11-03 1:13 ` Arnaldo Carvalho de Melo 2015-11-10 6:40 ` tip-bot for Peter Zijlstra [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tip-b71b437eedaed985062492565d9d421d975ae845@git.kernel.org \ --to=tipbot@zytor.com \ --cc=acme@kernel.org \ --cc=acme@redhat.com \ --cc=adrian.hunter@intel.com \ --cc=dsahern@gmail.com \ --cc=fweisbec@gmail.com \ --cc=hpa@zytor.com \ --cc=jolsa@kernel.org \ --cc=jolsa@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=wangnan0@huawei.com \ --subject='Re: [tip:perf/urgent] perf: Fix inherited events vs. tracepoint filters' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.