From: tip-bot for Andi Kleen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: ak@linux.intel.com, jolsa@kernel.org, tglx@linutronix.de,
mingo@kernel.org, acme@redhat.com, linux-kernel@vger.kernel.org,
hpa@zytor.com
Subject: [tip:perf/urgent] perf record: Remove suggestion to enable APIC
Date: Sat, 21 Apr 2018 00:52:24 -0700 [thread overview]
Message-ID: <tip-ccbb6afe0890b09cc828373a9a5fffab40ec85df@git.kernel.org> (raw)
In-Reply-To: <20180406203812.3087-5-andi@firstfloor.org>
Commit-ID: ccbb6afe0890b09cc828373a9a5fffab40ec85df
Gitweb: https://git.kernel.org/tip/ccbb6afe0890b09cc828373a9a5fffab40ec85df
Author: Andi Kleen <ak@linux.intel.com>
AuthorDate: Fri, 6 Apr 2018 13:38:12 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 18 Apr 2018 15:35:50 -0300
perf record: Remove suggestion to enable APIC
'perf record' suggests to enable the APIC on errors.
APIC is practically always used today and the problem is usually
somewhere else.
Just remove the outdated suggestion.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20180406203812.3087-5-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/evsel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 66b62570c855..3e87486c28fe 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2870,8 +2870,7 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,
#if defined(__i386__) || defined(__x86_64__)
if (evsel->attr.type == PERF_TYPE_HARDWARE)
return scnprintf(msg, size, "%s",
- "No hardware sampling interrupt available.\n"
- "No APIC? If so then you can boot the kernel with the \"lapic\" boot parameter to force-enable it.");
+ "No hardware sampling interrupt available.\n");
#endif
break;
case EBUSY:
next prev parent reply other threads:[~2018-04-21 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 20:38 Some minor fixes for perf user tools Andi Kleen
2018-04-06 20:38 ` [PATCH 1/4] perf, tools, mem: Allow all record/report options Andi Kleen
2018-04-21 7:50 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 2/4] perf, tools: Clarify browser help Andi Kleen
2018-04-21 7:51 ` [tip:perf/urgent] perf hists browser: Clarify top/report " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 3/4] perf, tools, record: Remove misleading error suggestion Andi Kleen
2018-04-21 7:51 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2018-04-06 20:38 ` [PATCH 4/4] perf, tools, record: Remove suggestion to enable APIC Andi Kleen
2018-04-21 7:52 ` tip-bot for Andi Kleen [this message]
2018-04-13 13:13 ` Some minor fixes for perf user tools Jiri Olsa
2018-04-13 14:33 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ccbb6afe0890b09cc828373a9a5fffab40ec85df@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.