From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754845AbdCGIpj (ORCPT ); Tue, 7 Mar 2017 03:45:39 -0500 Received: from terminus.zytor.com ([65.50.211.136]:34644 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbdCGIpb (ORCPT ); Tue, 7 Mar 2017 03:45:31 -0500 Date: Tue, 7 Mar 2017 00:20:52 -0800 From: "tip-bot for Steven Rostedt (VMware)" Message-ID: Cc: mhiramat@kernel.org, ananth@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, hpa@zytor.com, rostedt@goodmis.org, naveen.n.rao@linux.vnet.ibm.com, mingo@kernel.org, tglx@linutronix.de, mpe@ellerman.id.au, acme@redhat.com Reply-To: acme@redhat.com, ananth@linux.vnet.ibm.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, hpa@zytor.com, naveen.n.rao@linux.vnet.ibm.com, mpe@ellerman.id.au, tglx@linutronix.de, mingo@kernel.org In-Reply-To: <20170227115204.00f92846@gandalf.local.home> References: <20170227115204.00f92846@gandalf.local.home> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] trace/kprobes: Add back warning about offset in return probes Git-Commit-ID: d0e02579c282ccf34c79818045ec2d2934b56c19 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: d0e02579c282ccf34c79818045ec2d2934b56c19 Gitweb: http://git.kernel.org/tip/d0e02579c282ccf34c79818045ec2d2934b56c19 Author: Steven Rostedt (VMware) AuthorDate: Mon, 27 Feb 2017 11:52:04 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 3 Mar 2017 19:07:19 -0300 trace/kprobes: Add back warning about offset in return probes Let's not remove the warning about offsets and return probes when the offset is invalid. Signed-off-by: Steven Rostedt Acked-by: Masami Hiramatsu Acked-by: Naveen N. Rao Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Link: http://lkml.kernel.org/r/20170227115204.00f92846@gandalf.local.home Signed-off-by: Arnaldo Carvalho de Melo --- kernel/trace/trace_kprobe.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 18775ef..2b7d0dd 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -695,6 +695,11 @@ static int create_trace_kprobe(int argc, char **argv) pr_info("Failed to parse symbol.\n"); return ret; } + if (offset && is_return && + !arch_function_offset_within_entry(offset)) { + pr_info("Given offset is not valid for return probe.\n"); + return -EINVAL; + } } argc -= 2; argv += 2;