All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	castet.matthieu@free.fr, suresh.b.siddha@intel.com,
	mhopf@suse.de, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86, nx: Mark the ACPI resume trampoline code as +x
Date: Mon, 7 Feb 2011 09:24:55 GMT	[thread overview]
Message-ID: <tip-d344e38b2c151ca5e5e39f562017127e93912528@git.kernel.org> (raw)
In-Reply-To: <4D4F8019.2090104@zytor.com>

Commit-ID:  d344e38b2c151ca5e5e39f562017127e93912528
Gitweb:     http://git.kernel.org/tip/d344e38b2c151ca5e5e39f562017127e93912528
Author:     H. Peter Anvin <hpa@zytor.com>
AuthorDate: Sun, 6 Feb 2011 21:16:09 -0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 7 Feb 2011 09:07:13 +0100

x86, nx: Mark the ACPI resume trampoline code as +x

We reserve lowmem for the things that need it, like the ACPI
wakeup code, way early to guarantee availability.  This happens
before we set up the proper pagetables, so set_memory_x() has no
effect.

Until we have a better solution, use an initcall to mark the
wakeup code executable.

Originally-by: Matthieu Castet <castet.matthieu@free.fr>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Matthias Hopf <mhopf@suse.de>
Cc: rjw@sisk.pl
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
LKML-Reference: <4D4F8019.2090104@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/acpi/sleep.c |   13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index 4d9ebba..68d1537 100644
--- a/arch/x86/kernel/acpi/sleep.c
+++ b/arch/x86/kernel/acpi/sleep.c
@@ -12,10 +12,8 @@
 #include <linux/cpumask.h>
 #include <asm/segment.h>
 #include <asm/desc.h>
-
-#ifdef CONFIG_X86_32
 #include <asm/pgtable.h>
-#endif
+#include <asm/cacheflush.h>
 
 #include "realmode/wakeup.h"
 #include "sleep.h"
@@ -149,6 +147,15 @@ void __init acpi_reserve_wakeup_memory(void)
 	memblock_x86_reserve_range(mem, mem + WAKEUP_SIZE, "ACPI WAKEUP");
 }
 
+int __init acpi_configure_wakeup_memory(void)
+{
+	if (acpi_realmode)
+		set_memory_x(acpi_realmode, WAKEUP_SIZE >> PAGE_SHIFT);
+
+	return 0;
+}
+arch_initcall(acpi_configure_wakeup_memory);
+
 
 static int __init acpi_sleep_setup(char *str)
 {

  reply	other threads:[~2011-02-07  9:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 23:03 [PATCH] NX protection for kernel data : fix 32 bits S3 suspend matthieu castet
2011-02-01  8:02 ` Ingo Molnar
2011-02-01 13:25   ` castet.matthieu
2011-02-01 16:30     ` H. Peter Anvin
2011-02-02  6:26     ` Ingo Molnar
2011-02-03 22:11       ` H. Peter Anvin
2011-02-05  1:12       ` H. Peter Anvin
2011-02-05 16:46         ` castet.matthieu
2011-02-06 23:41           ` H. Peter Anvin
2011-02-07  7:40             ` Ingo Molnar
2011-02-07 19:59             ` castet.matthieu
2011-02-07 20:04               ` H. Peter Anvin
2011-02-12 16:10                 ` matthieu castet
2011-02-14 20:55                   ` H. Peter Anvin
2011-02-26  3:58                   ` Pavel Machek
2011-02-07 20:07               ` H. Peter Anvin
2011-02-14 21:19               ` H. Peter Anvin
2011-02-14 22:50                 ` Rafael J. Wysocki
2011-02-07  3:56           ` H. Peter Anvin
2011-02-07  5:16           ` H. Peter Anvin
2011-02-07  9:24             ` tip-bot for H. Peter Anvin [this message]
2011-02-07 14:50               ` [tip:x86/urgent] x86, nx: Mark the ACPI resume trampoline code as +x - fixed Marc Koschewski
2011-02-07 15:04                 ` Ingo Molnar
2011-02-07 13:16             ` [PATCH] NX protection for kernel data : fix 32 bits S3 suspend Matthias Hopf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-d344e38b2c151ca5e5e39f562017127e93912528@git.kernel.org \
    --to=hpa@zytor.com \
    --cc=castet.matthieu@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mhopf@suse.de \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.