From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932456AbdJJPBU (ORCPT ); Tue, 10 Oct 2017 11:01:20 -0400 Received: from terminus.zytor.com ([65.50.211.136]:49897 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756346AbdJJPBQ (ORCPT ); Tue, 10 Oct 2017 11:01:16 -0400 Date: Tue, 10 Oct 2017 07:56:22 -0700 From: tip-bot for Josh Poimboeuf Message-ID: Cc: penguin-kernel@I-love.SAKURA.ne.jp, linux-kernel@vger.kernel.org, byungchul.park@lge.com, tglx@linutronix.de, torvalds@linux-foundation.org, mingo@kernel.org, hpa@zytor.com, peterz@infradead.org, fengguang.wu@intel.com, jpoimboe@redhat.com, lkp@01.org Reply-To: torvalds@linux-foundation.org, mingo@kernel.org, hpa@zytor.com, byungchul.park@lge.com, penguin-kernel@I-love.SAKURA.ne.jp, linux-kernel@vger.kernel.org, tglx@linutronix.de, lkp@01.org, jpoimboe@redhat.com, fengguang.wu@intel.com, peterz@infradead.org In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/unwind: Disable unwinder warnings on 32-bit Git-Commit-ID: d4a2d031dd42f9594107d317e2a9a0c6d73ad46b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: d4a2d031dd42f9594107d317e2a9a0c6d73ad46b Gitweb: https://git.kernel.org/tip/d4a2d031dd42f9594107d317e2a9a0c6d73ad46b Author: Josh Poimboeuf AuthorDate: Mon, 9 Oct 2017 20:20:05 -0500 Committer: Ingo Molnar CommitDate: Tue, 10 Oct 2017 12:49:49 +0200 x86/unwind: Disable unwinder warnings on 32-bit x86-32 doesn't have stack validation, so in most cases it doesn't make sense to warn about bad frame pointers. Reported-by: Tetsuo Handa Signed-off-by: Josh Poimboeuf Cc: Byungchul Park Cc: Fengguang Wu Cc: LKP Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/a69658760800bf281e6353248c23e0fa0acf5230.1507597785.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/unwind_frame.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kernel/unwind_frame.c b/arch/x86/kernel/unwind_frame.c index 81aca07..3dc26f9 100644 --- a/arch/x86/kernel/unwind_frame.c +++ b/arch/x86/kernel/unwind_frame.c @@ -355,6 +355,13 @@ bad_address: state->regs->sp < (unsigned long)task_pt_regs(state->task)) goto the_end; + /* + * There are some known frame pointer issues on 32-bit. Disable + * unwinder warnings on 32-bit until it gets objtool support. + */ + if (IS_ENABLED(CONFIG_X86_32)) + goto the_end; + if (state->regs) { printk_deferred_once(KERN_WARNING "WARNING: kernel stack regs at %p in %s:%d has bad 'bp' value %p\n",