All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Sudip Mukherjee <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, sudip.mukherjee@codethink.co.uk,
	sudipm.mukherjee@gmail.com, cmetcalf@mellanox.com, hpa@zytor.com,
	mingo@kernel.org, tglx@linutronix.de, peterz@infradead.org
Subject: [tip:timers/core] math64, tile: Fix build failure
Date: Tue, 14 Feb 2017 00:43:02 -0800	[thread overview]
Message-ID: <tip-dba9a0babdd938a51d11ae81f9c40d07ca613f43@git.kernel.org> (raw)
In-Reply-To: <1485275961-20112-1-git-send-email-sudip.mukherjee@codethink.co.uk>

Commit-ID:  dba9a0babdd938a51d11ae81f9c40d07ca613f43
Gitweb:     http://git.kernel.org/tip/dba9a0babdd938a51d11ae81f9c40d07ca613f43
Author:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>
AuthorDate: Tue, 24 Jan 2017 16:39:21 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 14 Feb 2017 09:39:13 +0100

math64, tile: Fix build failure

The build of tilegx allmodconfig fails with:
../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
 static inline u64 mul_u32_u32(u32 a, u32 b)
               ^~~
../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                               ^~~
../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                                      ^~~
In file included from ../fs/ubifs/ubifs.h:26:0,
                 from ../fs/ubifs/shrinker.c:42:
../include/linux/math64.h: In function 'mul_u64_u32_shr':
../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
	function 'mul_u32_u32' [-Werror=implicit-function-declaration]

Include the linux/types.h in tiles div64.h to slve the problem.

Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends")
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: http://lkml.kernel.org/r/1485275961-20112-1-git-send-email-sudip.mukherjee@codethink.co.uk
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/tile/include/asm/div64.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/tile/include/asm/div64.h b/arch/tile/include/asm/div64.h
index bf61619..9f765cd 100644
--- a/arch/tile/include/asm/div64.h
+++ b/arch/tile/include/asm/div64.h
@@ -1,6 +1,8 @@
 #ifndef _ASM_TILE_DIV64_H
 #define _ASM_TILE_DIV64_H
 
+#include <linux/types.h>
+
 #ifdef __tilegx__
 static inline u64 mul_u32_u32(u32 a, u32 b)
 {

      parent reply	other threads:[~2017-02-14  8:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 16:39 [PATCH] tile: fix build failure Sudip Mukherjee
2017-01-24 16:56 ` Chris Metcalf
2017-02-13 22:58   ` Sudip Mukherjee
2017-02-13 23:01     ` Stephen Rothwell
2017-02-14  8:48       ` Thomas Gleixner
2017-02-14  8:43 ` tip-bot for Sudip Mukherjee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-dba9a0babdd938a51d11ae81f9c40d07ca613f43@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=cmetcalf@mellanox.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sudip.mukherjee@codethink.co.uk \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.