From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751119AbdDLFkj (ORCPT ); Wed, 12 Apr 2017 01:40:39 -0400 Received: from terminus.zytor.com ([65.50.211.136]:36771 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbdDLFke (ORCPT ); Wed, 12 Apr 2017 01:40:34 -0400 Date: Tue, 11 Apr 2017 22:37:58 -0700 From: tip-bot for Christian Borntraeger Message-ID: Cc: hpa@zytor.com, schwidefsky@de.ibm.com, krebbel@linux.vnet.ibm.com, borntraeger@de.ibm.com, brueckner@linux.vnet.ibm.com, acme@redhat.com, linux-s390@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org Reply-To: linux-s390@vger.kernel.org, acme@redhat.com, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org, hpa@zytor.com, borntraeger@de.ibm.com, krebbel@linux.vnet.ibm.com, schwidefsky@de.ibm.com, brueckner@linux.vnet.ibm.com In-Reply-To: <1491465112-45819-2-git-send-email-borntraeger@de.ibm.com> References: <1491465112-45819-2-git-send-email-borntraeger@de.ibm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf annotate s390: Fix perf annotate error -95 (4.10 regression) Git-Commit-ID: e77852b32d6d4430c68c38aaf73efe5650fa25af X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e77852b32d6d4430c68c38aaf73efe5650fa25af Gitweb: http://git.kernel.org/tip/e77852b32d6d4430c68c38aaf73efe5650fa25af Author: Christian Borntraeger AuthorDate: Thu, 6 Apr 2017 09:51:51 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 11 Apr 2017 15:23:39 -0300 perf annotate s390: Fix perf annotate error -95 (4.10 regression) since 4.10 perf annotate exits on s390 with an "unknown error -95". Turns out that commit 786c1b51844d ("perf annotate: Start supporting cross arch annotation") added a hard requirement for architecture support when objdump is used but only provided x86 and arm support. Meanwhile power was added so lets add s390 as well. While at it make sure to implement the branch and jump types. Signed-off-by: Christian Borntraeger Cc: Andreas Krebbel Cc: Hendrik Brueckner Cc: Martin Schwidefsky Cc: Peter Zijlstra Cc: linux-s390 Cc: stable@kernel.org # v4.10+ Fixes: 786c1b51844 "perf annotate: Start supporting cross arch annotation" Link: http://lkml.kernel.org/r/1491465112-45819-2-git-send-email-borntraeger@de.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/annotate.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index a37032b..bfb2f1d 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -130,6 +130,12 @@ static struct arch architectures[] = { .name = "powerpc", .init = powerpc__annotate_init, }, + { + .name = "s390", + .objdump = { + .comment_char = '#', + }, + }, }; static void ins__delete(struct ins_operands *ops)