From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38AFC43219 for ; Mon, 29 Apr 2019 18:47:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61DE02067D for ; Mon, 29 Apr 2019 18:47:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="lxcHRzsX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729272AbfD2SrG (ORCPT ); Mon, 29 Apr 2019 14:47:06 -0400 Received: from terminus.zytor.com ([198.137.202.136]:56093 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729200AbfD2Sqn (ORCPT ); Mon, 29 Apr 2019 14:46:43 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x3TIiRuC1030790 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 29 Apr 2019 11:44:27 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x3TIiRuC1030790 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019041745; t=1556563469; bh=SpcIPw3izbUD1OBVUMxyZW5hQOacs6cWzBORRy0E9sY=; h=Date:From:Cc:Reply-To:In-Reply-To:References:To:Subject:From; b=lxcHRzsXyeVGvTbh2MqbPyVEs+3XYIiRYjtkucAEIV42AC9YbYosGINff4Di6ZQ3+ R+Ug64KrWXgFImvVDUVCaRMxCvCnNlJS68UUdQirSP/SLgQBWCXYy3/xEx/GiFNGLH iIhup2uhYRD3o98CVXxqEeoOJFKxfDZCO2feUwfkgopvrAeXtS3ZA8r3pOwXjAfdrB uWf/8DvEXymWWPaflHfoICVJvLAbmzHcfjmLyxzrWbCuiPL8VvmcJS8McKUxMYN0IO 23sags6AKtgFgOFD43Q+U3aekoIfOIsEQVkTlpAzKVcUWMabOBOBawy1aQjU/MCaCH WViU2g8NXubaA== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x3TIiQno1030785; Mon, 29 Apr 2019 11:44:26 -0700 Date: Mon, 29 Apr 2019 11:44:26 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Thomas Gleixner Message-ID: Cc: jani.nikula@linux.intel.com, rppt@linux.vnet.ibm.com, airlied@linux.ie, rientjes@google.com, josef@toxicpanda.com, tom.zanussi@linux.intel.com, adobriyan@gmail.com, akpm@linux-foundation.org, jthumshirn@suse.de, aryabinin@virtuozzo.com, agk@redhat.com, maarten.lankhorst@linux.intel.com, luto@kernel.org, rostedt@goodmis.org, cl@linux.com, daniel@ffwll.ch, clm@fb.com, penberg@kernel.org, mbenes@suse.cz, snitzer@redhat.com, dvyukov@google.com, dsterba@suse.com, m.szyprowski@samsung.com, jpoimboe@redhat.com, hch@lst.de, linux-kernel@vger.kernel.org, glider@google.com, mingo@kernel.org, akinobu.mita@gmail.com, catalin.marinas@arm.com, robin.murphy@arm.com, tglx@linutronix.de, hpa@zytor.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com Reply-To: mbenes@suse.cz, snitzer@redhat.com, glider@google.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, m.szyprowski@samsung.com, hch@lst.de, dsterba@suse.com, dvyukov@google.com, catalin.marinas@arm.com, mingo@kernel.org, akinobu.mita@gmail.com, rodrigo.vivi@intel.com, hpa@zytor.com, joonas.lahtinen@linux.intel.com, robin.murphy@arm.com, tglx@linutronix.de, adobriyan@gmail.com, tom.zanussi@linux.intel.com, rientjes@google.com, josef@toxicpanda.com, jani.nikula@linux.intel.com, rppt@linux.vnet.ibm.com, airlied@linux.ie, maarten.lankhorst@linux.intel.com, agk@redhat.com, aryabinin@virtuozzo.com, akpm@linux-foundation.org, jthumshirn@suse.de, rostedt@goodmis.org, luto@kernel.org, penberg@kernel.org, daniel@ffwll.ch, clm@fb.com, cl@linux.com In-Reply-To: <20190425094802.979089273@linutronix.de> References: <20190425094802.979089273@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/stacktrace] tracing: Simplify stacktrace retrieval in histograms Git-Commit-ID: e7d916632b528e8cccc8e9ccca81acfc591a5fde X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e7d916632b528e8cccc8e9ccca81acfc591a5fde Gitweb: https://git.kernel.org/tip/e7d916632b528e8cccc8e9ccca81acfc591a5fde Author: Thomas Gleixner AuthorDate: Thu, 25 Apr 2019 11:45:13 +0200 Committer: Thomas Gleixner CommitDate: Mon, 29 Apr 2019 12:37:54 +0200 tracing: Simplify stacktrace retrieval in histograms The indirection through struct stack_trace is not necessary at all. Use the storage array based interface. Signed-off-by: Thomas Gleixner Tested-by: Tom Zanussi Reviewed-by: Tom Zanussi Reviewed-by: Josh Poimboeuf Acked-by: Steven Rostedt (VMware) Cc: Andy Lutomirski Cc: Alexander Potapenko Cc: Alexey Dobriyan Cc: Andrew Morton Cc: Christoph Lameter Cc: Pekka Enberg Cc: linux-mm@kvack.org Cc: David Rientjes Cc: Catalin Marinas Cc: Dmitry Vyukov Cc: Andrey Ryabinin Cc: kasan-dev@googlegroups.com Cc: Mike Rapoport Cc: Akinobu Mita Cc: Christoph Hellwig Cc: iommu@lists.linux-foundation.org Cc: Robin Murphy Cc: Marek Szyprowski Cc: Johannes Thumshirn Cc: David Sterba Cc: Chris Mason Cc: Josef Bacik Cc: linux-btrfs@vger.kernel.org Cc: dm-devel@redhat.com Cc: Mike Snitzer Cc: Alasdair Kergon Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: Joonas Lahtinen Cc: Maarten Lankhorst Cc: dri-devel@lists.freedesktop.org Cc: David Airlie Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Miroslav Benes Cc: linux-arch@vger.kernel.org Link: https://lkml.kernel.org/r/20190425094802.979089273@linutronix.de --- kernel/trace/trace_events_hist.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 21ceae299f7e..a1d20421f4b0 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -5186,7 +5186,6 @@ static void event_hist_trigger(struct event_trigger_data *data, void *rec, u64 var_ref_vals[TRACING_MAP_VARS_MAX]; char compound_key[HIST_KEY_SIZE_MAX]; struct tracing_map_elt *elt = NULL; - struct stack_trace stacktrace; struct hist_field *key_field; u64 field_contents; void *key = NULL; @@ -5198,14 +5197,9 @@ static void event_hist_trigger(struct event_trigger_data *data, void *rec, key_field = hist_data->fields[i]; if (key_field->flags & HIST_FIELD_FL_STACKTRACE) { - stacktrace.max_entries = HIST_STACKTRACE_DEPTH; - stacktrace.entries = entries; - stacktrace.nr_entries = 0; - stacktrace.skip = HIST_STACKTRACE_SKIP; - - memset(stacktrace.entries, 0, HIST_STACKTRACE_SIZE); - save_stack_trace(&stacktrace); - + memset(entries, 0, HIST_STACKTRACE_SIZE); + stack_trace_save(entries, HIST_STACKTRACE_DEPTH, + HIST_STACKTRACE_SKIP); key = entries; } else { field_contents = key_field->fn(key_field, elt, rbe, rec);