All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Thomas Gleixner <tglx@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	tglx@linutronix.de, kyle@parisc-linux.org
Subject: [tip:bkl/drivers] parisc: Remove BKL from eisa_eeprom
Date: Wed, 14 Oct 2009 15:50:29 GMT	[thread overview]
Message-ID: <tip-eb29b758a8b0b2dbffd8dc898490237d3ee783e4@git.kernel.org> (raw)
In-Reply-To: <20091010153350.086917493@linutronix.de>

Commit-ID:  eb29b758a8b0b2dbffd8dc898490237d3ee783e4
Gitweb:     http://git.kernel.org/tip/eb29b758a8b0b2dbffd8dc898490237d3ee783e4
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sat, 10 Oct 2009 15:33:17 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 14 Oct 2009 17:36:52 +0200

parisc: Remove BKL from eisa_eeprom

Remove the empty ioctl and the cycle_kernel_lock() in
eisa_eeprom_open() which got there with the big BKL push down. There
is nothing to wait for and sychronize with after the misc device has
been registered.

Remove the empty ioctl as well. The generic code handles the -ENOTTY
if no ioctl function is provided.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <20091010153350.086917493@linutronix.de>
Cc: Kyle McMartin <kyle@parisc-linux.org>
---
 drivers/parisc/eisa_eeprom.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/drivers/parisc/eisa_eeprom.c b/drivers/parisc/eisa_eeprom.c
index 8c0b26e..cce00ed 100644
--- a/drivers/parisc/eisa_eeprom.c
+++ b/drivers/parisc/eisa_eeprom.c
@@ -75,17 +75,8 @@ static ssize_t eisa_eeprom_read(struct file * file,
 	return ret;
 }
 
-static int eisa_eeprom_ioctl(struct inode *inode, struct file *file, 
-			   unsigned int cmd,
-			   unsigned long arg)
-{
-	return -ENOTTY;
-}
-
 static int eisa_eeprom_open(struct inode *inode, struct file *file)
 {
-	cycle_kernel_lock();
-
 	if (file->f_mode & FMODE_WRITE)
 		return -EINVAL;
    
@@ -104,7 +95,6 @@ static const struct file_operations eisa_eeprom_fops = {
 	.owner =	THIS_MODULE,
 	.llseek =	eisa_eeprom_llseek,
 	.read =		eisa_eeprom_read,
-	.ioctl =	eisa_eeprom_ioctl,
 	.open =		eisa_eeprom_open,
 	.release =	eisa_eeprom_release,
 };

  reply	other threads:[~2009-10-14 15:51 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-10 15:35 [patch 00/28] BKL removal queued patches Thomas Gleixner
2009-10-10 15:35 ` [patch 01/28] pm_qos: remove BKL Thomas Gleixner
2009-10-10 16:08   ` Frederic Weisbecker
2009-10-13 19:12   ` mgross
2009-10-13 19:21     ` Jonathan Corbet
2009-10-13 19:50       ` mgross
2009-10-14 15:44   ` [tip:bkl/core] " tip-bot for Jonathan Corbet
2009-10-10 15:35 ` [patch 02/28] pm_qos: clean up racy global "name" variable Thomas Gleixner
2009-10-10 19:54   ` John Kacur
2009-10-10 20:03     ` Jonathan Corbet
2009-10-10 20:09       ` Peter Zijlstra
2009-10-10 20:58       ` John Kacur
2009-10-14 15:44   ` [tip:bkl/core] " tip-bot for Jonathan Corbet
2009-10-10 15:35 ` [patch 03/28] net: Remove BKL from tun Thomas Gleixner
2009-10-14  8:19   ` David Miller
2009-10-10 15:35 ` [patch 04/28] x86: Remove BKL from microcode Thomas Gleixner
2009-10-14 15:14   ` [tip:x86/cleanups] " tip-bot for Thomas Gleixner
2009-10-10 15:35 ` [patch 05/28] drivers: Remove BKL from drivers/char/misc.c Thomas Gleixner
2009-10-11 19:24   ` Arnd Bergmann
2009-10-14 15:47   ` [tip:bkl/drivers] drivers: Remove BKL from misc_open tip-bot for Thomas Gleixner
2009-10-14 15:55     ` Arnd Bergmann
2009-10-14 16:07       ` Thomas Gleixner
2009-10-14 16:12     ` Alan Cox
2009-10-14 16:16       ` Thomas Gleixner
2009-10-14 16:54         ` Arnd Bergmann
2009-10-14 17:12           ` Arnd Bergmann
2009-10-14 19:38             ` Thomas Gleixner
2009-10-17 17:09               ` Pavel Machek
2009-10-14 18:12         ` Alan Cox
2009-10-14 19:34           ` Thomas Gleixner
2009-10-14 17:58       ` Ingo Molnar
2009-10-10 15:35 ` [patch 06/28] drivers: Remove BKL from cs5535_gpio Thomas Gleixner
2009-10-14 15:47   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-10 15:35 ` [patch 07/28] spi: Remove BKL from spidev_open Thomas Gleixner
2009-10-14 15:48   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-10 15:35 ` [patch 08/28] x86: Remove BKL from apm_32 Thomas Gleixner
2009-10-14 15:15   ` [tip:x86/cleanups] " tip-bot for Thomas Gleixner
2009-10-10 15:36 ` [patch 09/28] sys: Remove BKL from sys_reboot Thomas Gleixner
2009-10-14 15:44   ` [tip:bkl/core] " tip-bot for Thomas Gleixner
2009-10-10 15:36 ` [patch 10/28] mem_class: Drop the bkl from memory_open() Thomas Gleixner
2009-10-10 15:36 ` [patch 11/28] nvram: Drop the bkl from nvram_llseek() Thomas Gleixner
2009-10-11 19:31   ` Arnd Bergmann
2009-10-11 21:08     ` Frederic Weisbecker
2009-10-11 21:40       ` Frederic Weisbecker
2009-10-11 21:50         ` Arnd Bergmann
2009-10-11 22:14           ` Frederic Weisbecker
2009-10-13 12:40             ` Arnd Bergmann
2009-10-14 21:43               ` Thomas Gleixner
2009-10-11 22:12     ` [PATCH] generic_nvram: Turn nvram_ioctl into an unlocked ioctl Frederic Weisbecker
2009-10-11 22:25       ` Arnd Bergmann
2009-10-11 22:39         ` [PATCH v2] " Frederic Weisbecker
2009-10-11 22:40         ` [PATCH] " Frederic Weisbecker
2009-10-12  8:45           ` Arnd Bergmann
2009-10-10 15:36 ` [patch 12/28] nvram: Drop the bkl from non-generic nvram_llseek() Thomas Gleixner
2009-10-10 15:36 ` [patch 13/28] s390: Remove BKL from prng Thomas Gleixner
2009-10-13 12:36   ` Jan Glauber
2009-10-14 15:45   ` [tip:bkl/arch] " tip-bot for Thomas Gleixner
2009-10-10 15:36 ` [patch 14/28] um: Remove BKL from random Thomas Gleixner
2009-10-14 15:45   ` [tip:bkl/arch] " tip-bot for Thomas Gleixner
2009-10-10 15:36 ` [patch 15/28] um: Remove BKL from mmapper Thomas Gleixner
2009-10-14 15:45   ` [tip:bkl/arch] " tip-bot for Thomas Gleixner
2009-10-10 15:36 ` [patch 16/28] sparc: Remove BKL from apc Thomas Gleixner
2009-11-03  5:27   ` David Miller
2009-10-10 15:36 ` [patch 17/28] watchdog: Fix probe function of riowd Thomas Gleixner
2009-10-10 15:36 ` [patch 18/28] watchdog: Remove BKL from rio watchdog driver Thomas Gleixner
2009-11-03  5:16   ` David Miller
2009-10-10 15:36 ` [patch 19/28] hw_random: Remove BKL from core Thomas Gleixner
2009-10-14 15:49   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-21 20:51   ` [patch 19/28] " John Kacur
2009-10-10 15:36 ` [patch 20/28] input: Remove BKL from hp_sdc_rtc Thomas Gleixner
2009-10-11 19:47   ` Arnd Bergmann
2009-10-11 19:54     ` Thomas Gleixner
2009-10-14 15:49   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-10 15:37 ` [patch 21/28] bkl: pushdown BKL locking to do_sysctl() Thomas Gleixner
2009-10-11  9:03   ` Benjamin Herrenschmidt
2009-10-14 15:45   ` [tip:bkl/core] " tip-bot for Thomas Gleixner
2009-10-10 15:37 ` [patch 22/28] macintosh: Remove BKL from ans-lcd Thomas Gleixner
2009-10-10 15:37   ` Thomas Gleixner
2009-10-10 21:14   ` John Kacur
2009-10-10 21:14     ` John Kacur
2009-10-10 23:13     ` Alan Cox
2009-10-10 23:13       ` Alan Cox
2009-10-10 23:27       ` John Kacur
2009-10-10 23:27         ` John Kacur
2009-10-11  9:02   ` Benjamin Herrenschmidt
2009-10-11  9:02     ` Benjamin Herrenschmidt
2009-10-14 15:49   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-21 21:07   ` [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd John Kacur
2009-10-21 21:07     ` John Kacur
2009-10-21 21:21     ` Frederic Weisbecker
2009-10-21 21:21       ` Frederic Weisbecker
2009-10-21 21:33       ` John Kacur
2009-10-21 21:33         ` John Kacur
2009-10-21 21:45         ` Frederic Weisbecker
2009-10-21 21:45           ` Frederic Weisbecker
2009-10-21 21:53           ` John Kacur
2009-10-21 21:53             ` John Kacur
2009-10-21 22:16             ` Frederic Weisbecker
2009-10-21 22:16               ` Frederic Weisbecker
2009-11-02 15:51               ` Arnd Bergmann
2009-11-02 15:51                 ` Arnd Bergmann
2009-11-16 10:54                 ` Christoph Hellwig
2009-11-16 10:54                   ` Christoph Hellwig
2009-11-16 12:09                   ` Arnd Bergmann
2009-11-16 12:09                     ` Arnd Bergmann
2009-10-10 15:37 ` [patch 23/28] i2c: Remove big kernel lock from i2cdev_open Thomas Gleixner
2009-10-10 17:04   ` Jean Delvare
2009-10-10 17:09     ` Thomas Gleixner
2009-10-10 17:39       ` Jean Delvare
2009-10-10 18:10         ` Thomas Gleixner
2009-10-10 18:15           ` Peter Zijlstra
2009-10-10 18:38             ` Thomas Gleixner
2009-10-10 15:37 ` [patch 24/28] rtc: Remove BKL from efirtc Thomas Gleixner
2009-10-14 15:50   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-21 21:13   ` Subject: [PATCH] rtc: Explicitly set llseek to no_llseek John Kacur
2009-11-03 23:48     ` Andrew Morton
2009-11-04  0:43       ` John Kacur
2009-10-10 15:37 ` [patch 25/28] parisc: Remove BKL from eisa_eeprom Thomas Gleixner
2009-10-14 15:50   ` tip-bot for Thomas Gleixner [this message]
2009-10-14 17:35   ` Kyle McMartin
2009-10-10 15:37 ` [patch 26/28] drivers: Remove BKL from pc8736x_gpio Thomas Gleixner
2009-10-14 15:50   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-10 15:37 ` [patch 27/28] drivers: Remove BKL from scx200_gpio Thomas Gleixner
2009-10-14 15:50   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-10 15:37 ` [patch 28/28] mips: Remove BKL from tb0219 Thomas Gleixner
2009-10-14 15:51   ` [tip:bkl/drivers] " tip-bot for Thomas Gleixner
2009-10-10 18:38 ` [patch 00/28] BKL removal queued patches John Kacur
2009-10-14 15:59 ` [PATCH 1/2] compat_ioctl: remove VT specific ioctl handlers Arnd Bergmann
2009-10-14 16:00   ` [PATCH 2/2] compat_ioctl: do not hold BKL in handlers Arnd Bergmann
2009-10-14 16:10   ` [PATCH 1/2] compat_ioctl: remove VT specific ioctl handlers Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-eb29b758a8b0b2dbffd8dc898490237d3ee783e4@git.kernel.org \
    --to=tglx@linutronix.de \
    --cc=hpa@zytor.com \
    --cc=kyle@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.