From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25518C43219 for ; Mon, 29 Apr 2019 18:35:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF196215EA for ; Mon, 29 Apr 2019 18:35:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="qZCViHIW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729136AbfD2Sfx (ORCPT ); Mon, 29 Apr 2019 14:35:53 -0400 Received: from terminus.zytor.com ([198.137.202.136]:47499 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729130AbfD2Sfx (ORCPT ); Mon, 29 Apr 2019 14:35:53 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x3TIYkPd1027462 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 29 Apr 2019 11:34:46 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x3TIYkPd1027462 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019041745; t=1556562888; bh=tD78nErbFOXSLjomx3YZxxwA14XMQMWEldwwMWwz7JY=; h=Date:From:Cc:Reply-To:In-Reply-To:References:To:Subject:From; b=qZCViHIWeK7BMnVGyg8206MWsT3c/ZwJtmFJVqVMe7KR7aFW0DkYr3OBO/GdH3Adi lvX6wHs7nGqVtyWInIFeCzZ5G2J8m9lN72C6f/d3FCzkhdVyD8bFLLz0zZgRoUSXM4 iXXxICd/tf6n6kNFZ2eCM9lAGcME5LuXtyf23CEypq5853VZmdspckOKW0R7WMDG5x iv4PtyZpFWDDJHBVuAP3TRKUpdbdXeQQyQ/9kf6XVypNKbv9hXGC1nYjpmh5yIIrci 16j2j3EvYJu4jI7IxXS9z6ejJ7vr7lqiSl3llhwFPcotH71mIZIJivdGpWeC/0OMz9 4IIYU/RE8KgpA== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x3TIYktY1027458; Mon, 29 Apr 2019 11:34:46 -0700 Date: Mon, 29 Apr 2019 11:34:46 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Thomas Gleixner Message-ID: Cc: akpm@linux-foundation.org, akinobu.mita@gmail.com, penberg@kernel.org, luto@kernel.org, dvyukov@google.com, linux-kernel@vger.kernel.org, joonas.lahtinen@linux.intel.com, mbenes@suse.cz, rostedt@goodmis.org, jpoimboe@redhat.com, hpa@zytor.com, tglx@linutronix.de, rientjes@google.com, catalin.marinas@arm.com, robin.murphy@arm.com, rodrigo.vivi@intel.com, snitzer@redhat.com, agk@redhat.com, jthumshirn@suse.de, adobriyan@gmail.com, m.szyprowski@samsung.com, daniel@ffwll.ch, glider@google.com, aryabinin@virtuozzo.com, cl@linux.com, mingo@kernel.org, tom.zanussi@linux.intel.com, dsterba@suse.com, airlied@linux.ie, clm@fb.com, josef@toxicpanda.com, maarten.lankhorst@linux.intel.com, hch@lst.de, jani.nikula@linux.intel.com, rppt@linux.vnet.ibm.com Reply-To: josef@toxicpanda.com, maarten.lankhorst@linux.intel.com, hch@lst.de, jani.nikula@linux.intel.com, rppt@linux.vnet.ibm.com, tom.zanussi@linux.intel.com, mingo@kernel.org, dsterba@suse.com, airlied@linux.ie, clm@fb.com, jthumshirn@suse.de, adobriyan@gmail.com, m.szyprowski@samsung.com, aryabinin@virtuozzo.com, daniel@ffwll.ch, glider@google.com, cl@linux.com, rodrigo.vivi@intel.com, snitzer@redhat.com, agk@redhat.com, rientjes@google.com, tglx@linutronix.de, catalin.marinas@arm.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, joonas.lahtinen@linux.intel.com, mbenes@suse.cz, rostedt@goodmis.org, hpa@zytor.com, jpoimboe@redhat.com, penberg@kernel.org, luto@kernel.org, dvyukov@google.com, akpm@linux-foundation.org, akinobu.mita@gmail.com In-Reply-To: <20190425094801.683039030@linutronix.de> References: <20190425094801.683039030@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/stacktrace] latency_top: Simplify stack trace handling Git-Commit-ID: f93877214a83e88373b20801c2d671923d03d07d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: f93877214a83e88373b20801c2d671923d03d07d Gitweb: https://git.kernel.org/tip/f93877214a83e88373b20801c2d671923d03d07d Author: Thomas Gleixner AuthorDate: Thu, 25 Apr 2019 11:44:59 +0200 Committer: Thomas Gleixner CommitDate: Mon, 29 Apr 2019 12:37:48 +0200 latency_top: Simplify stack trace handling Replace the indirection through struct stack_trace with an invocation of the storage array based interface. Signed-off-by: Thomas Gleixner Reviewed-by: Josh Poimboeuf Cc: Andy Lutomirski Cc: Steven Rostedt Cc: Alexander Potapenko Cc: Alexey Dobriyan Cc: Andrew Morton Cc: Christoph Lameter Cc: Pekka Enberg Cc: linux-mm@kvack.org Cc: David Rientjes Cc: Catalin Marinas Cc: Dmitry Vyukov Cc: Andrey Ryabinin Cc: kasan-dev@googlegroups.com Cc: Mike Rapoport Cc: Akinobu Mita Cc: Christoph Hellwig Cc: iommu@lists.linux-foundation.org Cc: Robin Murphy Cc: Marek Szyprowski Cc: Johannes Thumshirn Cc: David Sterba Cc: Chris Mason Cc: Josef Bacik Cc: linux-btrfs@vger.kernel.org Cc: dm-devel@redhat.com Cc: Mike Snitzer Cc: Alasdair Kergon Cc: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org Cc: Joonas Lahtinen Cc: Maarten Lankhorst Cc: dri-devel@lists.freedesktop.org Cc: David Airlie Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Tom Zanussi Cc: Miroslav Benes Cc: linux-arch@vger.kernel.org Link: https://lkml.kernel.org/r/20190425094801.683039030@linutronix.de --- kernel/latencytop.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/kernel/latencytop.c b/kernel/latencytop.c index f5a90ab3c6b9..99a5b5f46dc5 100644 --- a/kernel/latencytop.c +++ b/kernel/latencytop.c @@ -141,20 +141,6 @@ account_global_scheduler_latency(struct task_struct *tsk, memcpy(&latency_record[i], lat, sizeof(struct latency_record)); } -/* - * Iterator to store a backtrace into a latency record entry - */ -static inline void store_stacktrace(struct task_struct *tsk, - struct latency_record *lat) -{ - struct stack_trace trace; - - memset(&trace, 0, sizeof(trace)); - trace.max_entries = LT_BACKTRACEDEPTH; - trace.entries = &lat->backtrace[0]; - save_stack_trace_tsk(tsk, &trace); -} - /** * __account_scheduler_latency - record an occurred latency * @tsk - the task struct of the task hitting the latency @@ -191,7 +177,8 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter) lat.count = 1; lat.time = usecs; lat.max = usecs; - store_stacktrace(tsk, &lat); + + stack_trace_save_tsk(tsk, lat.backtrace, LT_BACKTRACEDEPTH, 0); raw_spin_lock_irqsave(&latency_lock, flags);