All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Date: Tue, 15 Jun 2010 01:22:45 +0200 (CEST)	[thread overview]
raw)
In-Reply-To: <4C16AECD.50506@gmail.com>

which caused gcc 4.6 to warn about
    variable 'destination' set but not used.

Reported-by: Justin P. Mattock <justinmattock@gmail.com>

Since the hardware ensures that we receive only response packets with
proper destination node ID (in a given bus generation), we have no use
for destination here in the core as well as in upper layers.

(This is different with request packets.  There we pass destination node
ID to upper layers because they may for example need to check whether
this was an unicast or broadcast request.)

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/firewire/core-transaction.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Index: b/drivers/firewire/core-transaction.c
===================================================================
--- a/drivers/firewire/core-transaction.c
+++ b/drivers/firewire/core-transaction.c
@@ -881,13 +881,12 @@ void fw_core_handle_response(struct fw_c
 	unsigned long flags;
 	u32 *data;
 	size_t data_length;
-	int tcode, tlabel, destination, source, rcode;
+	int tcode, tlabel, source, rcode;
 
-	tcode       = HEADER_GET_TCODE(p->header[0]);
-	tlabel      = HEADER_GET_TLABEL(p->header[0]);
-	destination = HEADER_GET_DESTINATION(p->header[0]);
-	source      = HEADER_GET_SOURCE(p->header[1]);
-	rcode       = HEADER_GET_RCODE(p->header[1]);
+	tcode	= HEADER_GET_TCODE(p->header[0]);
+	tlabel	= HEADER_GET_TLABEL(p->header[0]);
+	source	= HEADER_GET_SOURCE(p->header[1]);
+	rcode	= HEADER_GET_RCODE(p->header[1]);
 
 	spin_lock_irqsave(&card->lock, flags);
 	list_for_each_entry(t, &card->transaction_list, link) {

-- 
Stefan Richter
-=====-==-=- -==- -====
http://arcgraph.de/sr/


  reply	other threads:[~2010-06-14 23:22 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-14 20:26 [PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 1/8]reiserfs:stree.c Fix variable set but not used Justin P. Mattock
2010-06-14 20:48   ` Nick Bowler
2010-06-14 20:48     ` Nick Bowler
     [not found]     ` <20100614204805.GA12589-7BP4RkwGw0uXmMXjJBpWqg@public.gmane.org>
2010-06-14 21:09       ` Justin P. Mattock
2010-06-14 21:09     ` Justin P. Mattock
2010-06-14 21:09       ` Justin P. Mattock
2010-06-14 21:05   ` Edward Shishkin
2010-06-14 21:05     ` Edward Shishkin
2010-06-14 21:21     ` Justin P. Mattock
2010-06-14 21:21       ` Justin P. Mattock
2010-06-14 21:47       ` Edward Shishkin
2010-06-14 22:50         ` Justin P. Mattock
2010-06-14 22:50           ` Justin P. Mattock
2010-06-14 23:07           ` Stefan Richter
2010-06-15  0:01             ` Justin P. Mattock
2010-06-15  0:01               ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-15  0:24   ` Gustavo F. Padovan
2010-06-15  0:24     ` Gustavo F. Padovan
2010-06-14 20:26 ` [PATCH 3/8]char/hpet.c Fix variable 'hpet' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-15  0:13   ` Valdis.Kletnieks
2010-06-15  0:13     ` Valdis.Kletnieks-PjAqaU27lzQ
2010-06-15  2:12     ` Justin P. Mattock
2010-06-15  2:12       ` Justin P. Mattock
2010-06-15  3:49       ` Valdis.Kletnieks
2010-06-15  3:49         ` Valdis.Kletnieks-PjAqaU27lzQ
2010-06-15  3:56         ` Justin P. Mattock
2010-06-15  5:29           ` Peter Stuge
2010-06-15  5:58             ` Justin P. Mattock
2010-06-15  5:58               ` Justin P. Mattock
2010-06-15  6:57               ` Stefan Richter
2010-06-15  7:27                 ` Justin P. Mattock
2010-06-15  7:56                   ` Stefan Richter
2010-06-15  8:30                     ` Justin P. Mattock
     [not found]             ` <20100615052944.7746.qmail-Y+HMSxxDrH8@public.gmane.org>
2010-06-15  5:58               ` Justin P. Mattock
2010-06-15  9:19             ` Jean Delvare
2010-06-15  9:19               ` Jean Delvare
2010-06-15  9:19               ` Jean Delvare
2010-06-15  9:19               ` Jean Delvare
2010-06-15  9:41               ` Justin P. Mattock
2010-06-15  9:41                 ` Justin P. Mattock
2010-06-15 18:53   ` Sergey V.
2010-06-15 18:53     ` Sergey V.
2010-06-15 19:36     ` Justin P. Mattock
2010-06-15 19:36       ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 5/8]drm:drm_gem Fix warning: variable 'dev' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-14 20:53   ` Jean Delvare
2010-06-14 21:06     ` Justin P. Mattock
2010-06-15 11:43       ` Jean Delvare
2010-06-15 11:43         ` Jean Delvare
2010-06-15 11:43         ` Jean Delvare
2010-06-15 11:43         ` Jean Delvare
2010-06-15 16:51         ` Justin P. Mattock
2010-06-14 21:28     ` David Daney
2010-06-15 11:40       ` Jean Delvare
2010-06-15 11:40         ` Jean Delvare
2010-06-15 16:20         ` David Daney
2010-06-15 16:20           ` David Daney
2010-06-16  9:45           ` Jean Delvare
2010-06-16  9:45             ` Jean Delvare
2010-06-16  9:45             ` Jean Delvare
2010-06-16  9:45             ` Jean Delvare
2010-06-14 20:26 ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-14 21:44   ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-14 22:35     ` Justin P. Mattock
2010-06-14 23:22       ` Stefan Richter [this message]
2010-06-14 23:58         ` Justin P. Mattock
2010-06-15  0:08         ` (no subject) Stefan Richter
2010-06-15  0:00       ` [PATCH] ieee1394: remove unused variables Stefan Richter
2010-06-15  0:05       ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-15  1:59         ` Justin P. Mattock
2010-06-15 11:38   ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used Jean Delvare
2010-06-15 11:38     ` Jean Delvare
2010-06-15 11:38     ` Jean Delvare
2010-06-15 16:52     ` Justin P. Mattock
2010-06-15 16:52       ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-15  5:16   ` Mauro Carvalho Chehab
2010-06-15  5:16     ` Mauro Carvalho Chehab
2010-06-15  5:37     ` Justin P. Mattock
2010-06-15  5:37       ` Justin P. Mattock
2010-06-15  5:50     ` Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.5070b3a06affdcfa@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.