From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.renesas.com ([202.234.163.13]:48424 "EHLO mail06.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751197AbZBTBLU (ORCPT ); Thu, 19 Feb 2009 20:11:20 -0500 Date: Fri, 20 Feb 2009 10:11:14 +0900 From: morimoto.kuninori@renesas.com Subject: Re: [PATCH 2/2] soc-camera: configure drivers with a default format on open In-reply-to: To: Guennadi Liakhovetski Cc: Linux Media Mailing List Message-id: MIME-version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-type: text/plain; charset=US-ASCII References: Sender: linux-media-owner@vger.kernel.org List-ID: Dear Guennadi > Currently soc-camera doesn't set up any image format without an explicit S_FMT. > It seems this should be supported, since, for example, capture-example.c from > v4l2-apps by default doesn't issue an S_FMT. This patch configures a default > image format on open(). > > Signed-off-by: Guennadi Liakhovetski > --- > > Morimoto-san, please, have a look how far these two patches take you, I > lost the track of the problems a bit:-) Does capture-example work for you > now without the "-f"? Oooops. sorry ov772x and tw9910 doesn't works... The reason is videobuf-core.c :: videobuf_next_field. BUG_ON(V4L2_FIELD_ANY == filed); sh_mobile_ceu use V4L2_FIELD_ANY now. and ov772x and tw9910 change field in try_fmt. But try_fmt isn't called... Best regards -- Kuninori Morimoto