All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE
Date: Thu, 09 Aug 2012 09:44:26 -1000	[thread overview]
Message-ID: <uiuqn4l019wk5s0l9cq2w0cy.1344541199595@email.android.com> (raw)

If you are going to add an explanation, then I would prefer a more complete one. Something like:
"Since more than one interface can be attached to a bridge, there still maybe an alternate path for netconsole to use; therefore there is no reason for a NETDEV_RELEASE event."

But my opinion it really isn't necessary to document what isn't done in the code, only what is done. The purpose of comments is to explain the wider impacts of the code.

             reply	other threads:[~2012-08-09 19:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 19:44 Stephen Hemminger [this message]
2012-08-10  2:38 ` [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE Cong Wang
  -- strict thread matches above, loose matches on Subject: below --
2012-08-10  7:10 [PATCH v4 00/14] some netpoll and netconsole fixes Cong Wang
2012-08-10  7:10 ` [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE Cong Wang
2012-08-09 15:00 [PATCH v3 0/14] some netpoll and netconsole fixes Cong Wang
2012-08-09 15:00 ` [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uiuqn4l019wk5s0l9cq2w0cy.1344541199595@email.android.com \
    --to=stephen.hemminger@vyatta.com \
    --cc=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.