All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Buslov <vladbu@mellanox.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vlad Buslov <vladbu@mellanox.com>,
	netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, jiri@resnulli.us, dcaratti@redhat.com,
	marcelo.leitner@gmail.com
Subject: Re: [PATCH net-next 0/4] Implement filter terse dump mode support
Date: Fri, 15 May 2020 14:25:50 +0300	[thread overview]
Message-ID: <vbfpnb5fni9.fsf@mellanox.com> (raw)
In-Reply-To: <20200514102647.5c581b5f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Thu 14 May 2020 at 20:26, Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 14 May 2020 14:40:22 +0300 Vlad Buslov wrote:
>> Implement support for terse dump mode which provides only essential
>> classifier/action info (handle, stats, cookie, etc.). Use new
>> TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from
>> kernel.
>
> Looks reasonable:
>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
>
> Apart from the change in NLA_BITFIELD policy build bot already pointed
> out there is also an unnecessary new line after a function in patch 2.

Hi Jakub,

Thanks for reviewing my code!
I'll send V2 with those two issues fixed.

Regards,
Vlad

      reply	other threads:[~2020-05-15 11:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 11:40 [PATCH net-next 0/4] Implement filter terse dump mode support Vlad Buslov
2020-05-14 11:40 ` [PATCH net-next 1/4] net: sched: introduce terse dump flag Vlad Buslov
2020-05-14 15:00   ` kbuild test robot
2020-05-14 15:00     ` kbuild test robot
2020-05-14 20:11   ` David Miller
2020-05-14 11:40 ` [PATCH net-next 2/4] net: sched: implement terse dump support in act Vlad Buslov
2020-05-14 11:40 ` [PATCH net-next 3/4] net: sched: cls_flower: implement terse dump support Vlad Buslov
2020-05-14 11:40 ` [PATCH net-next 4/4] selftests: implement flower classifier terse dump tests Vlad Buslov
2020-05-14 13:23 ` [PATCH iproute2-next 0/2] Implement filter terse dump mode support Vlad Buslov
2020-05-14 13:23   ` [PATCH iproute2-next 1/2] tc: skip actions that don't have options attribute when printing Vlad Buslov
2020-05-14 13:42     ` Jiri Pirko
2020-05-14 13:23   ` [PATCH iproute2-next 2/2] tc: implement support for terse dump Vlad Buslov
2020-05-14 13:42     ` Jiri Pirko
2020-05-21 18:01   ` [PATCH iproute2-next 0/2] Implement filter terse dump mode support David Ahern
2020-06-01 18:58     ` David Ahern
2020-05-14 17:26 ` [PATCH net-next 0/4] " Jakub Kicinski
2020-05-15 11:25   ` Vlad Buslov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vbfpnb5fni9.fsf@mellanox.com \
    --to=vladbu@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.