From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbbCIQ5w (ORCPT ); Mon, 9 Mar 2015 12:57:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50392 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbbCIQ5t (ORCPT ); Mon, 9 Mar 2015 12:57:49 -0400 From: Mitchel Humpherys To: Yong Wu Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Catalin Marinas , Joerg Roedel , Will Deacon , linux-kernel@vger.kernel.org, Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , Daniel Kurtz , Sasha Hauer , Matthias Brugger , linux-mediatek@lists.infradead.org, Robin Murphy , linux-arm-kernel@lists.infradead.org, Lucas Stach Subject: Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver References: <1425638900-24989-1-git-send-email-yong.wu@mediatek.com> <1425638900-24989-3-git-send-email-yong.wu@mediatek.com> <1425903386.13300.33.camel@mhfsdcap03> Date: Mon, 09 Mar 2015 09:57:45 -0700 In-Reply-To: <1425903386.13300.33.camel@mhfsdcap03> (Yong Wu's message of "Mon, 9 Mar 2015 20:16:26 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09 2015 at 05:16:26 AM, Yong Wu wrote: > Dear Mitchel, > Thanks very much for your review. > > On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote: >> On Fri, Mar 06 2015 at 02:48:17 AM, wrote: >> > From: Yong Wu >> > >> > This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). >> > Currently this only supports m4u gen 2 with 2 levels of page table on mt8173. >> >> [...] >> >> > +static int mtk_iommu_invalidate_tlb(const struct mtk_iommu_info *piommu, >> > + int isinvall, unsigned int iova_start, >> > + unsigned int iova_end) >> > +{ >> > + void __iomem *m4u_base = piommu->m4u_base; >> > + u32 val; >> > + u64 start, end; >> > + >> > + start = sched_clock(); >> > + >> > + if (!isinvall) { >> > + iova_start = round_down(iova_start, SZ_4K); >> > + iova_end = round_up(iova_end, SZ_4K); >> > + } >> > + >> > + val = F_MMU_INV_EN_L2 | F_MMU_INV_EN_L1; >> > + >> > + writel(val, m4u_base + REG_INVLID_SEL); >> > + >> > + if (isinvall) { >> > + writel(F_MMU_INV_ALL, m4u_base + REG_MMU_INVLD); >> > + } else { >> > + writel(iova_start, m4u_base + REG_MMU_INVLD_SA); >> > + writel(iova_end, m4u_base + REG_MMU_INVLD_EA); >> > + writel(F_MMU_INV_RANGE, m4u_base + REG_MMU_INVLD); >> > + >> > + while (!readl(m4u_base + REG_MMU_CPE_DONE)) { >> > + end = sched_clock(); >> > + if (end - start >= 100000000ULL) { >> > + dev_warn(piommu->dev, "invalid don't done\n"); >> > + writel(F_MMU_INV_ALL, m4u_base + REG_MMU_INVLD); >> > + } >> > + }; >> >> Superfluous `;'. Also, maybe you should be using readl_poll_timeout? > Thanks. > For the "readl_poll_timeout", My base is 3.19-rc7 and robin's patch. > it don't have this interface. I will try to add it in the next version. Yeah it was merged in v4.0-rc1. -Mitch -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: mitchelh@codeaurora.org (Mitchel Humpherys) Date: Mon, 09 Mar 2015 09:57:45 -0700 Subject: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver In-Reply-To: <1425903386.13300.33.camel@mhfsdcap03> (Yong Wu's message of "Mon, 9 Mar 2015 20:16:26 +0800") References: <1425638900-24989-1-git-send-email-yong.wu@mediatek.com> <1425638900-24989-3-git-send-email-yong.wu@mediatek.com> <1425903386.13300.33.camel@mhfsdcap03> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 09 2015 at 05:16:26 AM, Yong Wu wrote: > Dear Mitchel, > Thanks very much for your review. > > On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote: >> On Fri, Mar 06 2015 at 02:48:17 AM, wrote: >> > From: Yong Wu >> > >> > This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). >> > Currently this only supports m4u gen 2 with 2 levels of page table on mt8173. >> >> [...] >> >> > +static int mtk_iommu_invalidate_tlb(const struct mtk_iommu_info *piommu, >> > + int isinvall, unsigned int iova_start, >> > + unsigned int iova_end) >> > +{ >> > + void __iomem *m4u_base = piommu->m4u_base; >> > + u32 val; >> > + u64 start, end; >> > + >> > + start = sched_clock(); >> > + >> > + if (!isinvall) { >> > + iova_start = round_down(iova_start, SZ_4K); >> > + iova_end = round_up(iova_end, SZ_4K); >> > + } >> > + >> > + val = F_MMU_INV_EN_L2 | F_MMU_INV_EN_L1; >> > + >> > + writel(val, m4u_base + REG_INVLID_SEL); >> > + >> > + if (isinvall) { >> > + writel(F_MMU_INV_ALL, m4u_base + REG_MMU_INVLD); >> > + } else { >> > + writel(iova_start, m4u_base + REG_MMU_INVLD_SA); >> > + writel(iova_end, m4u_base + REG_MMU_INVLD_EA); >> > + writel(F_MMU_INV_RANGE, m4u_base + REG_MMU_INVLD); >> > + >> > + while (!readl(m4u_base + REG_MMU_CPE_DONE)) { >> > + end = sched_clock(); >> > + if (end - start >= 100000000ULL) { >> > + dev_warn(piommu->dev, "invalid don't done\n"); >> > + writel(F_MMU_INV_ALL, m4u_base + REG_MMU_INVLD); >> > + } >> > + }; >> >> Superfluous `;'. Also, maybe you should be using readl_poll_timeout? > Thanks. > For the "readl_poll_timeout", My base is 3.19-rc7 and robin's patch. > it don't have this interface. I will try to add it in the next version. Yeah it was merged in v4.0-rc1. -Mitch -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project