From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH v2 07/10] ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams Date: Thu, 08 Oct 2015 20:40:26 +0200 Message-ID: References: <1444295885-1657-1-git-send-email-Karthik.188@gmail.com> <1444295885-1657-8-git-send-email-Karthik.188@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org, christian.couder@gmail.com, gitster@pobox.com To: Karthik Nayak X-From: git-owner@vger.kernel.org Thu Oct 08 20:40:41 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZkG7J-0008WC-6f for gcvg-git-2@plane.gmane.org; Thu, 08 Oct 2015 20:40:37 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753935AbbJHSkd (ORCPT ); Thu, 8 Oct 2015 14:40:33 -0400 Received: from mx1.imag.fr ([129.88.30.5]:43898 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798AbbJHSkc (ORCPT ); Thu, 8 Oct 2015 14:40:32 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id t98IeOhV010358 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 8 Oct 2015 20:40:25 +0200 Received: from anie (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t98IeQMU009437; Thu, 8 Oct 2015 20:40:26 +0200 In-Reply-To: <1444295885-1657-8-git-send-email-Karthik.188@gmail.com> (Karthik Nayak's message of "Thu, 8 Oct 2015 14:48:02 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Thu, 08 Oct 2015 20:40:25 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t98IeOhV010358 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1444934426.6669@SIPlDjZmFqjTYHKMuEeGWQ Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Karthik Nayak writes: > --- a/ref-filter.c > +++ b/ref-filter.c > @@ -1118,8 +1118,10 @@ static void populate_value(struct ref_array_item *ref) > char buf[40]; > > if (stat_tracking_info(branch, &num_ours, > - &num_theirs, NULL)) > + &num_theirs, NULL)) { > + v->s = "[gone]"; My remark about translation still holds. The string was previously translated in "branch" and you are removing this translation (well, not here, but when 09/10 starts using this code). -- Matthieu Moy http://www-verimag.imag.fr/~moy/