From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Michael Witten <mfwitten@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Huynh Khoi Nguyen Nguyen
<Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>,
git@vger.kernel.org
Subject: Re: [PATCH 2/3] Testing: XDG config files: Use "$HOME" and "$XDG_CONFIG_HOME" explicitly
Date: Tue, 17 Jul 2012 20:19:16 +0200 [thread overview]
Message-ID: <vpqehoap7x7.fsf@bauges.imag.fr> (raw)
In-Reply-To: <e118f47351094d4fb45dd34bc08b9e9b-mfwitten@gmail.com> (Michael Witten's message of "Tue, 17 Jul 2012 16:41:21 -0000")
Michael Witten <mfwitten@gmail.com> writes:
> The tests in:
>
> t/t1306-xdg-files.sh
>
> relied on brittle conventions:
>
> * "$HOME" and "$XDG_CONFIG_HOME" having certain values.
>
> * The testing commands having a certain current working
> directory;
Other tests (t1305-config-include.sh at least) use the fact that the
tests are ran in $HOME. I'm not sure if we want to change that.
About XDG_CONFIG_HOME, the tests were just assuming it was unset.
> +GIT_CONFIG_DIR=$XDG_CONFIG_HOME/git
As I said in my earlier message, I'd rather test the default value
($HOME/.config/git) than the particular case whe $XDG_CONFIG_HOME is
set.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2012-07-17 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 17:25 [PATCH 0/3] Testing: XDG config files: Fix broken tests Michael Witten
2012-07-17 16:41 ` [PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable Michael Witten
2012-07-17 17:57 ` Jonathan Nieder
2012-07-17 18:14 ` Matthieu Moy
2012-07-17 18:31 ` Junio C Hamano
2012-07-17 16:41 ` [PATCH 2/3] Testing: XDG config files: Use "$HOME" and "$XDG_CONFIG_HOME" explicitly Michael Witten
2012-07-17 18:19 ` Matthieu Moy [this message]
2012-07-17 16:41 ` [PATCH 3/3] Testing: XDG config files: Trivial: `xdg' -> `XDG' Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqehoap7x7.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mfwitten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.